[pushed] gdb: constify target_stack::is_pushed

[pushed] gdb: constify target_stack::is_pushed

[Simon Marchi]

The target_ops parameters here can be made const.

Change-Id: Ibc18b17d6b21d06145251a03e68aca90538117d6
---
 gdb/inferior.h | 2 +-
 gdb/target.h   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/inferior.h b/gdb/inferior.h
index 017800165b4b..bb3aec1e8f80 100644
--- a/gdb/inferior.h
+++ b/gdb/inferior.h
@@ -369,7 +369,7 @@ class inferior : public refcounted_object,
   int unpush_target (struct target_ops *t);
 
   /* Returns true if T is pushed in this inferior's target stack.  */
-  bool target_is_pushed (target_ops *t)
+  bool target_is_pushed (const target_ops *t)
   { return m_target_stack.is_pushed (t); }
 
   /* Find the target beneath T in this inferior's target stack.  */
diff --git a/gdb/target.h b/gdb/target.h
index 0b784278c4f8..8e13ada07b6a 100644
--- a/gdb/target.h
+++ b/gdb/target.h
@@ -1385,7 +1385,7 @@ class target_stack
   bool unpush (target_ops *t);
 
   /* Returns true if T is pushed on the target stack.  */
-  bool is_pushed (target_ops *t) const
+  bool is_pushed (const target_ops *t) const
   { return at (t->stratum ()) == t; }
 
   /* Return the target at STRATUM.  */

base-commit: ac9b8c676e9f52c5238bbc61a2cdd27e3d59db10
-- 
2.37.3

Re: [pushed] gdb: constify target_stack::is_pushed

[Tom Tromey]

>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:

Simon> The target_ops parameters here can be made const.

Simon> -  bool target_is_pushed (target_ops *t)
Simon> +  bool target_is_pushed (const target_ops *t)

Seems like this one could also be const-qualified, like this one is:

Simon> +  bool is_pushed (const target_ops *t) const
Simon>    { return at (t->stratum ()) == t; }

thanks,
Tom

Re: [pushed] gdb: constify target_stack::is_pushed

[Simon Marchi]

On 2022-09-29 18:42, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Simon> The target_ops parameters here can be made const.
> 
> Simon> -  bool target_is_pushed (target_ops *t)
> Simon> +  bool target_is_pushed (const target_ops *t)
> 
> Seems like this one could also be const-qualified, like this one is:
> 
> Simon> +  bool is_pushed (const target_ops *t) const
> Simon>    { return at (t->stratum ()) == t; }

Thanks, I just pushed a patch that does that.

Simon