Re: [PATCH] Fix for gdb.base/solib-search.exp test.

[Simon Marchi <simark@simark.ca>]

On 2022-03-22 17:49, Carl Love via Gdb-patches wrote:
>
> GDB maintainers:
>
> The following patch fixes the setting of the variable right_lib_flags
> in the solib-search.exp test.  With the fix the test now run correctly
> on Powerpc.
>
> The patch has been tested on a Power 10 system.
>
> Please let me know if the patch is acceptable for mainline gdb.
> Thanks.
>
>                       Carl Love
>
> ---------------------------------------------------
> Fix for gdb.base/solib-search.exp test.
>
> The variable right_lib_flags is not being set correctly to define RIGHT.
> The value RIGHT is needed to force the address of the library functions
> lib1_func3 and lib2_func4 to occur at different address in the wrong and
> right libraries.
>
> With RIGHT defined correctly, functions lib1_func3 and lib2_func4 occur
> at different addresses the test runs correctly on Powerpc.
> ---
>  gdb/testsuite/gdb.base/solib-search.exp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/gdb.base/solib-search.exp b/gdb/testsuite/gdb.base/solib-search.exp
> index eaabe508bf0..202e79d85de 100644
> --- a/gdb/testsuite/gdb.base/solib-search.exp
> +++ b/gdb/testsuite/gdb.base/solib-search.exp
> @@ -54,7 +54,7 @@ set binfile2_lib [standard_output_file ${libname2}.so]
>
>  set lib_flags [list debug ldflags=-Wl,-Bsymbolic]
>  set wrong_lib_flags "$lib_flags additional_flags=-DARRAY_SIZE=1"
> -set right_lib_flags "$lib_flags additional_flags=-DARRAY_SIZE=8192 -DRIGHT"
> +set right_lib_flags "$lib_flags additional_flags=-DARRAY_SIZE=8192 additional_flags=-DRIGHT"

Hi Carl,

Intuitively, this looks good.  But I'd like to understand why this fails
on PPC but not x86-64.  Can you show the failure that you see?  It's
also a good idea to put it in the commit log for future reference.  You
can paste the FAIL line that you get before the patch, and the PASS line
that you get after the patch.  Include the relevant lines from gdb.log
just before those, so we can see what changed between before and after.

Simon