Re: [PATCH] Fix for gdb.base/solib-search.exp test.

[will schmidt <will_schmidt@vnet.ibm.com>]

On Tue, 2022-03-22 at 14:49 -0700, Carl Love wrote:
> GDB maintainers:
> 
> The following patch fixes the setting of the variable right_lib_flags
> in the solib-search.exp test.  With the fix the test now run
> correctly
> on Powerpc.
> 
> The patch has been tested on a Power 10 system.
> 
> Please let me know if the patch is acceptable for mainline gdb. 
> Thanks.
> 
>                       Carl Love
> 
> ---------------------------------------------------
> Fix for gdb.base/solib-search.exp test.
> 
> The variable right_lib_flags is not being set correctly to define
> RIGHT.
> The value RIGHT is needed to force the address of the library
> functions
> lib1_func3 and lib2_func4 to occur at different address in the wrong
> and
> right libraries.
> 
> With RIGHT defined correctly, functions lib1_func3 and lib2_func4
> occur
> at different addresses the test runs correctly on Powerpc.
> ---
>  gdb/testsuite/gdb.base/solib-search.exp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gdb/testsuite/gdb.base/solib-search.exp
> b/gdb/testsuite/gdb.base/solib-search.exp
> index eaabe508bf0..202e79d85de 100644
> --- a/gdb/testsuite/gdb.base/solib-search.exp
> +++ b/gdb/testsuite/gdb.base/solib-search.exp
> @@ -54,7 +54,7 @@ set binfile2_lib [standard_output_file
> ${libname2}.so]
> 
>  set lib_flags [list debug ldflags=-Wl,-Bsymbolic]
>  set wrong_lib_flags "$lib_flags additional_flags=-DARRAY_SIZE=1"
> -set right_lib_flags "$lib_flags additional_flags=-DARRAY_SIZE=8192
> -DRIGHT"
> +set right_lib_flags "$lib_flags additional_flags=-DARRAY_SIZE=8192
> additional_flags=-DRIGHT"
> 

This change seems reasonable.  Presumably the DARRAY_SIZE change
introduced enough delta such that the test passed on other archs, and
PowerPC was simply unlucky to catch the error.

This change may fall under "obvious" , since it's a fix to the
arguments used for the test, and post-fix now matches the style used in
other tests with more than one argument.  Particularly in comparison
with the existing vsx-vsr-float28.exp test.
Maybe an informal chat in the GDB IRC chat to confirm the guidelines
for obvious.  :-)

Thanks
-Will
>  # Binary file.
>  standard_testfile .c