From: Carl Love <cel@us.ibm.com>
To: dje@google.com, gdb-patches@sourceware.org
Cc: cel@us.ibm.com, Will Schmidt <will_schmidt@vnet.ibm.com>,
Rogerio Alves <rogealve@br.ibm.com>
Subject: [PATCH] Fix for gdb.base/solib-search.exp test.
Date: Tue, 22 Mar 2022 14:49:07 -0700 [thread overview]
Message-ID: <8fe6f3bee129c0a3159d3ef57c942b9473255d8d.camel@us.ibm.com> (raw)
GDB maintainers:
The following patch fixes the setting of the variable right_lib_flags
in the solib-search.exp test. With the fix the test now run correctly
on Powerpc.
The patch has been tested on a Power 10 system.
Please let me know if the patch is acceptable for mainline gdb.
Thanks.
Carl Love
---------------------------------------------------
Fix for gdb.base/solib-search.exp test.
The variable right_lib_flags is not being set correctly to define RIGHT.
The value RIGHT is needed to force the address of the library functions
lib1_func3 and lib2_func4 to occur at different address in the wrong and
right libraries.
With RIGHT defined correctly, functions lib1_func3 and lib2_func4 occur
at different addresses the test runs correctly on Powerpc.
---
gdb/testsuite/gdb.base/solib-search.exp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.base/solib-search.exp b/gdb/testsuite/gdb.base/solib-search.exp
index eaabe508bf0..202e79d85de 100644
--- a/gdb/testsuite/gdb.base/solib-search.exp
+++ b/gdb/testsuite/gdb.base/solib-search.exp
@@ -54,7 +54,7 @@ set binfile2_lib [standard_output_file ${libname2}.so]
set lib_flags [list debug ldflags=-Wl,-Bsymbolic]
set wrong_lib_flags "$lib_flags additional_flags=-DARRAY_SIZE=1"
-set right_lib_flags "$lib_flags additional_flags=-DARRAY_SIZE=8192 -DRIGHT"
+set right_lib_flags "$lib_flags additional_flags=-DARRAY_SIZE=8192 additional_flags=-DRIGHT"
# Binary file.
standard_testfile .c
--
2.31.1
next reply other threads:[~2022-03-22 21:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 21:49 Carl Love [this message]
2022-03-28 15:21 ` [PING] " Carl Love
2022-04-07 15:13 ` [PING 2] " Carl Love
2022-04-21 1:49 ` [PING 3] " Carl Love
2022-04-21 13:39 ` Simon Marchi
2022-04-21 18:21 ` Carl Love
2022-04-21 19:04 ` Simon Marchi
2022-04-21 19:16 ` Carl Love
2022-04-21 15:05 ` will schmidt
2022-05-02 14:16 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fe6f3bee129c0a3159d3ef57c942b9473255d8d.camel@us.ibm.com \
--to=cel@us.ibm.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=rogealve@br.ibm.com \
--cc=will_schmidt@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).