public inbox for
 help / color / mirror / Atom feed
From: Simon Marchi <>
To: Tom Tromey <>,
	Simon Marchi via Gdb-patches <>
Cc: Simon Marchi <>
Subject: Re: [PATCH 2/2] gdb/dwarf: rename cooked_index_vector to cooked_index
Date: Tue, 31 Jan 2023 22:09:53 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 1/31/23 15:56, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <> writes:
> Simon> See previous patch's commit message for rationale.
> I've found that "previous" is more confusing when reading the git log.
> Maybe just a reference to the _shard rename would be sufficient here
> though.
> Approved-By: Tom Tromey <>

Argh, I'm tired, and I pushed the patches before addressing your
comment, sorry about that.


  reply	other threads:[~2023-02-01  3:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-31 18:27 [PATCH 1/2] gdb/dwarf: rename cooked_index to cooked_index_shard Simon Marchi
2023-01-31 18:27 ` [PATCH 2/2] gdb/dwarf: rename cooked_index_vector to cooked_index Simon Marchi
2023-01-31 20:56   ` Tom Tromey
2023-02-01  3:09     ` Simon Marchi [this message]
2023-02-01  3:42       ` Tom Tromey
2023-01-31 20:55 ` [PATCH 1/2] gdb/dwarf: rename cooked_index to cooked_index_shard Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).