From: Bernd Edlinger <bernd.edlinger@hotmail.de>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [PATCH 1/2] sim: riscv: fix a divw division by -1 bug
Date: Mon, 15 Apr 2024 16:46:37 +0200 [thread overview]
Message-ID: <AS8P193MB1285190D16ECDFD0DD14DBE6E4092@AS8P193MB1285.EURP193.PROD.OUTLOOK.COM> (raw)
There is a bug in divw for riscv64 target
with dividing by -1, the result was always 0,
when it should in fact be sign-extended -dividend.
It did not affect the rv32 target, because
these instructions are rv64 only.
Since 1 << 31 is an integer overflow this avoids
an undefined behaviour bug at the same time.
This caused test failures in the gcc testsuite like:
FAIL: gcc.c-torture/execute/arith-rand-ll.c -O0 execution test
FAIL: gcc.c-torture/execute/arith-rand-ll.c -O1 execution test
FAIL: gcc.c-torture/execute/arith-rand-ll.c -O2 execution test
FAIL: gcc.c-torture/execute/arith-rand-ll.c -O3 execution test
FAIL: gcc.c-torture/execute/arith-rand.c -O0 execution test
FAIL: gcc.c-torture/execute/arith-rand.c -O1 execution test
FAIL: gcc.c-torture/execute/arith-rand.c -O2 execution test
FAIL: gcc.c-torture/execute/arith-rand.c -O3 execution test
...
---
sim/riscv/sim-main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sim/riscv/sim-main.c b/sim/riscv/sim-main.c
index c8adb65139b..515ff835223 100644
--- a/sim/riscv/sim-main.c
+++ b/sim/riscv/sim-main.c
@@ -724,7 +724,7 @@ execute_m (SIM_CPU *cpu, unsigned_word iw, const struct riscv_opcode *op)
rd_name, rs1_name, rs2_name, rd_name, rs1_name, rs2_name);
RISCV_ASSERT_RV64 (cpu, "insn: %s", op->name);
if (EXTEND32 (riscv_cpu->regs[rs2]) == -1)
- tmp = 1 << 31;
+ tmp = EXTEND32 (-(uint32_t) riscv_cpu->regs[rs1]);
else if (EXTEND32 (riscv_cpu->regs[rs2]))
tmp = EXTEND32 (riscv_cpu->regs[rs1]) / EXTEND32 (riscv_cpu->regs[rs2]);
else
--
2.39.2
reply other threads:[~2024-04-15 14:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8P193MB1285190D16ECDFD0DD14DBE6E4092@AS8P193MB1285.EURP193.PROD.OUTLOOK.COM \
--to=bernd.edlinger@hotmail.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).