* [PATCH 1/2] sim: riscv: fix a divw division by -1 bug
@ 2024-04-15 14:46 Bernd Edlinger
0 siblings, 0 replies; only message in thread
From: Bernd Edlinger @ 2024-04-15 14:46 UTC (permalink / raw)
To: gdb-patches
There is a bug in divw for riscv64 target
with dividing by -1, the result was always 0,
when it should in fact be sign-extended -dividend.
It did not affect the rv32 target, because
these instructions are rv64 only.
Since 1 << 31 is an integer overflow this avoids
an undefined behaviour bug at the same time.
This caused test failures in the gcc testsuite like:
FAIL: gcc.c-torture/execute/arith-rand-ll.c -O0 execution test
FAIL: gcc.c-torture/execute/arith-rand-ll.c -O1 execution test
FAIL: gcc.c-torture/execute/arith-rand-ll.c -O2 execution test
FAIL: gcc.c-torture/execute/arith-rand-ll.c -O3 execution test
FAIL: gcc.c-torture/execute/arith-rand.c -O0 execution test
FAIL: gcc.c-torture/execute/arith-rand.c -O1 execution test
FAIL: gcc.c-torture/execute/arith-rand.c -O2 execution test
FAIL: gcc.c-torture/execute/arith-rand.c -O3 execution test
...
---
sim/riscv/sim-main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sim/riscv/sim-main.c b/sim/riscv/sim-main.c
index c8adb65139b..515ff835223 100644
--- a/sim/riscv/sim-main.c
+++ b/sim/riscv/sim-main.c
@@ -724,7 +724,7 @@ execute_m (SIM_CPU *cpu, unsigned_word iw, const struct riscv_opcode *op)
rd_name, rs1_name, rs2_name, rd_name, rs1_name, rs2_name);
RISCV_ASSERT_RV64 (cpu, "insn: %s", op->name);
if (EXTEND32 (riscv_cpu->regs[rs2]) == -1)
- tmp = 1 << 31;
+ tmp = EXTEND32 (-(uint32_t) riscv_cpu->regs[rs1]);
else if (EXTEND32 (riscv_cpu->regs[rs2]))
tmp = EXTEND32 (riscv_cpu->regs[rs1]) / EXTEND32 (riscv_cpu->regs[rs2]);
else
--
2.39.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-04-15 14:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-15 14:46 [PATCH 1/2] sim: riscv: fix a divw division by -1 bug Bernd Edlinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).