RE: [Ping v2] [PATCH 1/1] gdb, testsuite: Adapt gdb.base/callfuncs.exp for new clang warnings.

RE: [Ping v2] [PATCH 1/1] gdb, testsuite: Adapt gdb.base/callfuncs.exp for new clang warnings.

[Willgerodt, Felix]

*ping* v2

Thanks,
Felix

> -----Original Message-----
> From: Willgerodt, Felix
> Sent: Mittwoch, 22. Juni 2022 10:40
> To: gdb-patches@sourceware.org
> Subject: RE: [Ping] [PATCH 1/1] gdb, testsuite: Adapt gdb.base/callfuncs.exp
> for new clang warnings.
> 
> *ping*
> 
> Thanks,
> Felix
> 
> > -----Original Message-----
> > From: Willgerodt, Felix <felix.willgerodt@intel.com>
> > Sent: Mittwoch, 8. Juni 2022 09:17
> > To: gdb-patches@sourceware.org
> > Cc: Willgerodt, Felix <felix.willgerodt@intel.com>
> > Subject: [PATCH 1/1] gdb, testsuite: Adapt gdb.base/callfuncs.exp for new
> > clang warnings.
> >
> > This patch fixes two issues with callfuncs.exp, which are both related
> > to new Clang warnings:
> >
> > 1) Clang 15.0.0 added a new warning for deprecated non-prototype
> > functions:
> > https://reviews.llvm.org/D122895
> > Callfuncs.exp is impacted and won't run due to new warnings:
> >
> > callfuncs.c:339:5: warning: a function declaration without a prototype is
> > deprecated in all versions of C and is not supported in C2x
> > [-Wdeprecated-non-prototype]
> > int t_float_values (float_arg1, float_arg2)
> >
> > This patch disables those warnings with -Wno-deprecated-non-prototype.
> > Removing the test for deprecated syntax would also be an option. But I will
> > leave that for others to decide.
> >
> > 2) The other new warnings are about comparing a define with floats and
> > doubles:
> >
> > callfuncs.c:518:1: warning: floating-point comparison is always true;
> constant
> > cannot be represented exactly in type 'float' [-Wliteral-range]
> > DEF_FUNC_VALUES_3(fc, float, crealf, cimagf)
> >
> > This can be fixed by making the define a float.
> > ---
> >  gdb/testsuite/gdb.base/callfuncs.c   | 2 +-
> >  gdb/testsuite/gdb.base/callfuncs.exp | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/gdb/testsuite/gdb.base/callfuncs.c
> > b/gdb/testsuite/gdb.base/callfuncs.c
> > index d18d0dba073..cf7c75c1360 100644
> > --- a/gdb/testsuite/gdb.base/callfuncs.c
> > +++ b/gdb/testsuite/gdb.base/callfuncs.c
> > @@ -96,7 +96,7 @@ long double _Complex ldc3 = 3.0L + 3.0Li;
> >  long double _Complex ldc4 = 4.0L + 4.0Li;
> >  #endif /* TEST_COMPLEX */
> >
> > -#define DELTA (0.001)
> > +#define DELTA (0.001f)
> >
> >  char *string_val1 = (char *)"string 1";
> >  char *string_val2 = (char *)"string 2";
> > diff --git a/gdb/testsuite/gdb.base/callfuncs.exp
> > b/gdb/testsuite/gdb.base/callfuncs.exp
> > index 4448cc127ba..d74357b8b48 100644
> > --- a/gdb/testsuite/gdb.base/callfuncs.exp
> > +++ b/gdb/testsuite/gdb.base/callfuncs.exp
> > @@ -18,7 +18,7 @@
> >
> >  standard_testfile
> >
> > -set compile_flags {debug}
> > +set compile_flags {debug additional_flags=-Wno-deprecated-non-
> > prototype}
> >  if [support_complex_tests] {
> >      lappend compile_flags "additional_flags=-DTEST_COMPLEX"
> >  }
> > --
> > 2.34.3

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

RE: [Ping v2] [PATCH 1/1] gdb, testsuite: Adapt gdb.base/callfuncs.exp for new clang warnings.

[George, Jini Susan]

[Public]

LGTM. (Not an approver, though). Thanks for doing this!

Thanks,
Jini.

>>-----Original Message-----
>>From: Gdb-patches <gdb-patches-
>>bounces+jigeorge=amd.com@sourceware.org> On Behalf Of Willgerodt, Felix
>>via Gdb-patches
>>Sent: Wednesday, June 29, 2022 12:50 PM
>>To: gdb-patches@sourceware.org
>>Subject: RE: [Ping v2] [PATCH 1/1] gdb, testsuite: Adapt gdb.base/callfuncs.exp
>>for new clang warnings.
>>
>>[CAUTION: External Email]
>>
>>*ping* v2
>>
>>Thanks,
>>Felix
>>
>>> -----Original Message-----
>>> From: Willgerodt, Felix
>>> Sent: Mittwoch, 22. Juni 2022 10:40
>>> To: gdb-patches@sourceware.org
>>> Subject: RE: [Ping] [PATCH 1/1] gdb, testsuite: Adapt
>>> gdb.base/callfuncs.exp for new clang warnings.
>>>
>>> *ping*
>>>
>>> Thanks,
>>> Felix
>>>
>>> > -----Original Message-----
>>> > From: Willgerodt, Felix <felix.willgerodt@intel.com>
>>> > Sent: Mittwoch, 8. Juni 2022 09:17
>>> > To: gdb-patches@sourceware.org
>>> > Cc: Willgerodt, Felix <felix.willgerodt@intel.com>
>>> > Subject: [PATCH 1/1] gdb, testsuite: Adapt gdb.base/callfuncs.exp
>>> > for new clang warnings.
>>> >
>>> > This patch fixes two issues with callfuncs.exp, which are both
>>> > related to new Clang warnings:
>>> >
>>> > 1) Clang 15.0.0 added a new warning for deprecated non-prototype
>>> > functions:
>>> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fre
>>> >
>>views.llvm.org%2FD122895&amp;data=05%7C01%7CJiniSusan.George%40amd.
>>c
>>> >
>>om%7Ccef6651a3a784a1682fb08da599fd701%7C3dd8961fe4884e608e11a82d9
>>94e
>>> >
>>183d%7C0%7C0%7C637920840304960717%7CUnknown%7CTWFpbGZsb3d8eyJ
>>WIjoiMC
>>> >
>>4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C
>>%7
>>> >
>>C%7C&amp;sdata=imVO5B0vvv3%2B8rDeeI7vC%2F0lUSk2oCHbye1WevxCm6k
>>%3D&am
>>> > p;reserved=0 Callfuncs.exp is impacted and won't run due to new
>>> > warnings:
>>> >
>>> > callfuncs.c:339:5: warning: a function declaration without a
>>> > prototype is deprecated in all versions of C and is not supported in
>>> > C2x [-Wdeprecated-non-prototype] int t_float_values (float_arg1,
>>> > float_arg2)
>>> >
>>> > This patch disables those warnings with -Wno-deprecated-non-prototype.
>>> > Removing the test for deprecated syntax would also be an option. But
>>> > I will leave that for others to decide.
>>> >
>>> > 2) The other new warnings are about comparing a define with floats
>>> > and
>>> > doubles:
>>> >
>>> > callfuncs.c:518:1: warning: floating-point comparison is always
>>> > true;
>>> constant
>>> > cannot be represented exactly in type 'float' [-Wliteral-range]
>>> > DEF_FUNC_VALUES_3(fc, float, crealf, cimagf)
>>> >
>>> > This can be fixed by making the define a float.
>>> > ---
>>> >  gdb/testsuite/gdb.base/callfuncs.c   | 2 +-
>>> >  gdb/testsuite/gdb.base/callfuncs.exp | 2 +-
>>> >  2 files changed, 2 insertions(+), 2 deletions(-)
>>> >
>>> > diff --git a/gdb/testsuite/gdb.base/callfuncs.c
>>> > b/gdb/testsuite/gdb.base/callfuncs.c
>>> > index d18d0dba073..cf7c75c1360 100644
>>> > --- a/gdb/testsuite/gdb.base/callfuncs.c
>>> > +++ b/gdb/testsuite/gdb.base/callfuncs.c
>>> > @@ -96,7 +96,7 @@ long double _Complex ldc3 = 3.0L + 3.0Li;  long
>>> > double _Complex ldc4 = 4.0L + 4.0Li;  #endif /* TEST_COMPLEX */
>>> >
>>> > -#define DELTA (0.001)
>>> > +#define DELTA (0.001f)
>>> >
>>> >  char *string_val1 = (char *)"string 1";  char *string_val2 = (char
>>> > *)"string 2"; diff --git a/gdb/testsuite/gdb.base/callfuncs.exp
>>> > b/gdb/testsuite/gdb.base/callfuncs.exp
>>> > index 4448cc127ba..d74357b8b48 100644
>>> > --- a/gdb/testsuite/gdb.base/callfuncs.exp
>>> > +++ b/gdb/testsuite/gdb.base/callfuncs.exp
>>> > @@ -18,7 +18,7 @@
>>> >
>>> >  standard_testfile
>>> >
>>> > -set compile_flags {debug}
>>> > +set compile_flags {debug additional_flags=-Wno-deprecated-non-
>>> > prototype}
>>> >  if [support_complex_tests] {
>>> >      lappend compile_flags "additional_flags=-DTEST_COMPLEX"
>>> >  }
>>> > --
>>> > 2.34.3
>>
>>Intel Deutschland GmbH
>>Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
>>Tel: +49 89 99 8853-0,
>>https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.int
>>el.de%2F&amp;data=05%7C01%7CJiniSusan.George%40amd.com%7Ccef6651a
>>3a784a1682fb08da599fd701%7C3dd8961fe4884e608e11a82d994e183d%7C0%
>>7C0%7C637920840304960717%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wL
>>jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C
>>%7C&amp;sdata=Zoltodx7rLK1UwtZDmLCxGiKZnDUXSXq%2F6T9scBY6JQ%3D&a
>>mp;reserved=0
>><https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.in
>>tel.de%2F&amp;data=05%7C01%7CJiniSusan.George%40amd.com%7Ccef6651a
>>3a784a1682fb08da599fd701%7C3dd8961fe4884e608e11a82d994e183d%7C0%
>>7C0%7C637920840304960717%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wL
>>jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C
>>%7C&amp;sdata=Zoltodx7rLK1UwtZDmLCxGiKZnDUXSXq%2F6T9scBY6JQ%3D&a
>>mp;reserved=0>
>>Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
>>Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich
>>Commercial Register: Amtsgericht Muenchen HRB 186928