From: Andrei Pikas <gdb@mail.api.win>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 (mentions of reverse mode eliminated)] Add style tui-cursorline command to colorize TUI current line.
Date: Mon, 18 Jul 2022 18:32:39 +0300 [thread overview]
Message-ID: <CAAVp0Jto=ysJRyoaHT6VWGYPtVTOpQw69TcAdiPCrnYktB=cZw@mail.gmail.com> (raw)
In-Reply-To: <87tu7eqzfa.fsf@redhat.com>
> > This is to support all 256 colors
> > https://www.ditig.com/256-colors-cheat-sheet . I want to use the
> > lightest shade of gray #255 for the background.
>
> Thanks. I've been playing with adding 256 colour support to GDB.
>
> I think this change is big enough that it should be split into a
> separate patch.
Do you think it's OK to set colors as enum without corresponding
numbers for colors 0-7?
Or maybe it would be better to add something like case var_color: into
do_set_command to support all possible colors which
ui_file_style::color supports?
Or maybe just to store value as simple var_string, but to extend
struct cmd_list_element with custom validation function, to validate
color string at the time of setting, rather then on first use?
next prev parent reply other threads:[~2022-07-18 15:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-09 19:05 [PATCH] Add style tui-reverse " Andrei Pikas
2022-07-09 19:10 ` Eli Zaretskii
2022-07-09 20:20 ` [PATCH] Add style tui-cursorline " Andrei Pikas
2022-07-10 5:03 ` Eli Zaretskii
2022-07-10 10:10 ` [PATCH v2 (mentions of reverse mode eliminated)] " Andrei Pikas
2022-07-10 10:19 ` Eli Zaretskii
2022-07-15 19:40 ` Tom Tromey
2022-07-15 22:06 ` Andrei Pikas
2022-07-18 14:16 ` Andrew Burgess
2022-07-18 15:32 ` Andrei Pikas [this message]
2022-07-18 18:12 ` Tom Tromey
2022-07-15 22:49 ` [PATCH v3] Add style tui-current-line " Andrei Pikas
2022-07-16 5:35 ` Eli Zaretskii
2022-07-18 14:30 ` Andrew Burgess
2022-07-18 19:11 ` [PATCH v4 (fix formatting and revert cli_colors to original state)] " Andrei Pikas
2022-07-18 19:14 ` Eli Zaretskii
2022-07-18 19:16 ` Andrei Pikas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAVp0Jto=ysJRyoaHT6VWGYPtVTOpQw69TcAdiPCrnYktB=cZw@mail.gmail.com' \
--to=gdb@mail.api.win \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).