From: Andrei Pikas <gdb@mail.api.win>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v4 (fix formatting and revert cli_colors to original state)] Add style tui-current-line command to colorize TUI current line.
Date: Mon, 18 Jul 2022 22:16:02 +0300 [thread overview]
Message-ID: <c4bd8b4c-cb20-129f-4aa3-1e0ab9b032c5@mail.api.win> (raw)
In-Reply-To: <83o7xmnsh4.fsf@gnu.org>
> The documentation parts are unchanged since I approved them, right?
Yes, it's right.
On 18/07/2022 22:14, Eli Zaretskii wrote:
>> From: Andrei Pikas <gdb@mail.api.win>
>> Date: Mon, 18 Jul 2022 22:11:18 +0300
>> Cc: Andrei Pikas <gdb@mail.api.win>, aburgess@redhat.com
>>
>> Adds the ability to customize the colors of the current line of code in TUI.
>> This may be desirable when code highlighting is enabled. Because higlighted
>> keywords in dark blue color are indistinguishable from a black background
>> (which is the default inverse color for a white terminal).
>> Here is a screenshot of old and new behavior
>> https://drive.google.com/file/d/1RnrDjvdsnV8y_lrnavs6wvQ6lXbtjRup/view
>> ---
>> gdb/NEWS | 4 ++++
>> gdb/cli/cli-style.c | 14 ++++++++++++++
>> gdb/cli/cli-style.h | 3 +++
>> gdb/doc/gdb.texinfo | 3 +++
>> gdb/tui/tui-io.c | 44 ++++++++++++++++++++++++++++++++++++++++----
>> gdb/tui/tui-win.c | 1 +
>> 6 files changed, 65 insertions(+), 4 deletions(-)
> The documentation parts are unchanged since I approved them, right?
>
> Thanks.
prev parent reply other threads:[~2022-07-18 19:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-09 19:05 [PATCH] Add style tui-reverse " Andrei Pikas
2022-07-09 19:10 ` Eli Zaretskii
2022-07-09 20:20 ` [PATCH] Add style tui-cursorline " Andrei Pikas
2022-07-10 5:03 ` Eli Zaretskii
2022-07-10 10:10 ` [PATCH v2 (mentions of reverse mode eliminated)] " Andrei Pikas
2022-07-10 10:19 ` Eli Zaretskii
2022-07-15 19:40 ` Tom Tromey
2022-07-15 22:06 ` Andrei Pikas
2022-07-18 14:16 ` Andrew Burgess
2022-07-18 15:32 ` Andrei Pikas
2022-07-18 18:12 ` Tom Tromey
2022-07-15 22:49 ` [PATCH v3] Add style tui-current-line " Andrei Pikas
2022-07-16 5:35 ` Eli Zaretskii
2022-07-18 14:30 ` Andrew Burgess
2022-07-18 19:11 ` [PATCH v4 (fix formatting and revert cli_colors to original state)] " Andrei Pikas
2022-07-18 19:14 ` Eli Zaretskii
2022-07-18 19:16 ` Andrei Pikas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4bd8b4c-cb20-129f-4aa3-1e0ab9b032c5@mail.api.win \
--to=gdb@mail.api.win \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).