[PATCH] gettext: disable install, docs targets, libasprintf, threads

[PATCH] gettext: disable install, docs targets, libasprintf, threads

[Arsen Arsenović]

This fixes issues reported by David Edelsohn <dje.gcc@gmail.com>, and by
Eric Gallager <egallager@gcc.gnu.org>.

ChangeLog:

	* Makefile.def (gettext): Disable (via missing)
	{install-,}{pdf,html,info,dvi} and TAGS targets.  Set no_install
	to true.  Add --disable-threads --disable-libasprintf.  Drop the
	lib_path (as there are no shared libs).
---
Afternoon,

This patch disables various targets and features on the gettext module
to fix problems reported by David Edelsohn and Eric Gallager in
https://inbox.sourceware.org/CAGWvnynmWgNjup4cAwSbsy1vw_MJLQqSULwM=kTH_+Lt+_smbg@mail.gmail.com/
and followups and on IRC, respectively.

The gettext module does not actually require any of these to be usable
for the purposes of the toolchain, so disabling them seems to be a
decent workaround.

This seemed to fix the respective issues for both Eric and David,
though, I could not get GDB to build on AIX with or without this patch
applied (I needed to disable sim, gdb and gnulib modules).

It is possible I am missing something.  Due to some unfortunate
circumstances, it's taken more time than anticipated to actually get
this change tested, and I've had to context swap quite a few bits.  Such
a process has quite a lot of room for error.

Tested on x86_64-unknown-freebsd13.2.

 Makefile.def |  13 +++-
 Makefile.in  | 202 ++++++++-------------------------------------------
 [removed regenerated file from the patch below]
 2 files changed, 40 insertions(+), 175 deletions(-)

diff --git a/Makefile.def b/Makefile.def
index 792f81447e1b..ba89d46b2495 100644
--- a/Makefile.def
+++ b/Makefile.def
@@ -80,8 +80,17 @@ host_modules= { module= gettext; bootstrap=true; no_install=true;
 		// need it in some configuratons, which is determined via nontrivial tests.
 		// Always enabling pic seems to make sense for something tied to
 		// user-facing output.
-                extra_configure_flags='--disable-shared --disable-java --disable-csharp --with-pic';
-                lib_path=intl/.libs; };
+		extra_configure_flags='--disable-shared --disable-threads --disable-java --disable-csharp --with-pic --disable-libasprintf';
+		missing= pdf;
+		missing= html;
+		missing= info;
+		missing= dvi;
+		missing= install-pdf;
+		missing= install-html;
+		missing= install-info;
+		missing= install-dvi;
+		missing= TAGS;
+		no_install= true; };
 host_modules= { module= tcl;
                 missing=mostlyclean; };
 host_modules= { module= itcl; };
diff --git a/Makefile.in b/Makefile.in
index da2344b3f3dc..3bd7d37e9605 100644
 
-- 
2.43.0

Re: [PATCH] gettext: disable install, docs targets, libasprintf, threads

[Richard Biener]

On Sat, Dec 2, 2023 at 5:03 PM Arsen Arsenović <arsen@aarsen.me> wrote:
>
> This fixes issues reported by David Edelsohn <dje.gcc@gmail.com>, and by
> Eric Gallager <egallager@gcc.gnu.org>.
>
> ChangeLog:
>
>         * Makefile.def (gettext): Disable (via missing)
>         {install-,}{pdf,html,info,dvi} and TAGS targets.  Set no_install
>         to true.  Add --disable-threads --disable-libasprintf.  Drop the
>         lib_path (as there are no shared libs).
> ---
> Afternoon,
>
> This patch disables various targets and features on the gettext module
> to fix problems reported by David Edelsohn and Eric Gallager in
> https://inbox.sourceware.org/CAGWvnynmWgNjup4cAwSbsy1vw_MJLQqSULwM=kTH_+Lt+_smbg@mail.gmail.com/
> and followups and on IRC, respectively.
>
> The gettext module does not actually require any of these to be usable
> for the purposes of the toolchain, so disabling them seems to be a
> decent workaround.
>
> This seemed to fix the respective issues for both Eric and David,
> though, I could not get GDB to build on AIX with or without this patch
> applied (I needed to disable sim, gdb and gnulib modules).
>
> It is possible I am missing something.  Due to some unfortunate
> circumstances, it's taken more time than anticipated to actually get
> this change tested, and I've had to context swap quite a few bits.  Such
> a process has quite a lot of room for error.
>
> Tested on x86_64-unknown-freebsd13.2.

OK.

>  Makefile.def |  13 +++-
>  Makefile.in  | 202 ++++++++-------------------------------------------
>  [removed regenerated file from the patch below]
>  2 files changed, 40 insertions(+), 175 deletions(-)
>
> diff --git a/Makefile.def b/Makefile.def
> index 792f81447e1b..ba89d46b2495 100644
> --- a/Makefile.def
> +++ b/Makefile.def
> @@ -80,8 +80,17 @@ host_modules= { module= gettext; bootstrap=true; no_install=true;
>                 // need it in some configuratons, which is determined via nontrivial tests.
>                 // Always enabling pic seems to make sense for something tied to
>                 // user-facing output.
> -                extra_configure_flags='--disable-shared --disable-java --disable-csharp --with-pic';
> -                lib_path=intl/.libs; };
> +               extra_configure_flags='--disable-shared --disable-threads --disable-java --disable-csharp --with-pic --disable-libasprintf';
> +               missing= pdf;
> +               missing= html;
> +               missing= info;
> +               missing= dvi;
> +               missing= install-pdf;
> +               missing= install-html;
> +               missing= install-info;
> +               missing= install-dvi;
> +               missing= TAGS;
> +               no_install= true; };
>  host_modules= { module= tcl;
>                  missing=mostlyclean; };
>  host_modules= { module= itcl; };
> diff --git a/Makefile.in b/Makefile.in
> index da2344b3f3dc..3bd7d37e9605 100644
>
> --
> 2.43.0
>

Re: [PATCH] gettext: disable install, docs targets, libasprintf, threads

[Arsen Arsenović]

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]


Richard Biener <richard.guenther@gmail.com> writes:

> OK.

Thanks.  I'll wait for the Binutils and GDB maintainers to weigh in
before pushing (plus, I can't push there).

Have a lovely day!
-- 
Arsen Arsenović

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 381 bytes --]

Re: [PATCH] gettext: disable install, docs targets, libasprintf, threads

[Tom Tromey]

>>>>> "Arsen" == Arsen Arsenović <arsen@aarsen.me> writes:

Arsen> Thanks.  I'll wait for the Binutils and GDB maintainers to weigh in
Arsen> before pushing (plus, I can't push there).

Seems fine to me.  Thank you.

Tom

Re: [PATCH] gettext: disable install, docs targets, libasprintf, threads

[Eric Gallager]

On Mon, Dec 4, 2023 at 1:44 PM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> "Arsen" == Arsen Arsenović <arsen@aarsen.me> writes:
>
> Arsen> Thanks.  I'll wait for the Binutils and GDB maintainers to weigh in
> Arsen> before pushing (plus, I can't push there).
>
> Seems fine to me.  Thank you.
>
> Tom

LGTM; please post once it has been committed.
Thanks,
Eric