From: Alexandra Petlanova Hajkova <ahajkova@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove OBJF_REORDERED
Date: Tue, 28 Feb 2023 12:22:35 +0100 [thread overview]
Message-ID: <CAJVr-EOjNsfYEGTxHovUR6NjFnhgMVbFKNpnz13KS-kP-UO=+Q@mail.gmail.com> (raw)
In-Reply-To: <20230226185808.2677822-1-tom@tromey.com>
[-- Attachment #1: Type: text/plain, Size: 870 bytes --]
On Sun, Feb 26, 2023 at 8:00 PM Tom Tromey <tom@tromey.com> wrote:
> OBJF_REORDERED is set for nearly every object format. And, despite
> the ominous warnings here and there, it does not seem very expensive.
> This patch removes the flag entirely.
> ---
> gdb/buildsym.c | 20 ++++++++------------
> gdb/coffread.c | 5 -----
> gdb/elfread.c | 4 ----
> gdb/machoread.c | 4 +---
> gdb/mdebugread.c | 29 -----------------------------
> gdb/objfile-flags.h | 22 +++++++---------------
> gdb/psymtab.c | 3 +--
> gdb/symfile.c | 2 +-
> gdb/symtab.c | 17 +++++------------
> gdb/xcoffread.c | 5 -----
> 10 files changed, 23 insertions(+), 88 deletions(-)
>
> diff --git a/gdb/buildsym.c b/gdb/buildsym.c
> index dbc81727cb1..8b6cb616d71 100644
>
>
I think it's a nice simplification and a reasonable thing to do.
next prev parent reply other threads:[~2023-02-28 11:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-26 18:58 Tom Tromey
2023-02-28 11:22 ` Alexandra Petlanova Hajkova [this message]
2023-02-28 15:28 ` Andrew Burgess
2023-03-08 19:11 ` Tom Tromey
2023-03-01 3:34 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJVr-EOjNsfYEGTxHovUR6NjFnhgMVbFKNpnz13KS-kP-UO=+Q@mail.gmail.com' \
--to=ahajkova@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).