public inbox for
 help / color / mirror / Atom feed
From: Alexandra Petlanova Hajkova <>
To: Tom Tromey <>
Subject: Re: [PATCH 1/5] Save breakpoints so they are automatically pending
Date: Tue, 31 Jan 2023 16:14:54 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

[-- Attachment #1: Type: text/plain, Size: 1330 bytes --]

On Sun, Jan 29, 2023 at 5:21 PM Tom Tromey <> wrote:

> PR breakpoints/18183 points out that breakpoints saved with the "save
> breakpoints" command can be slightly inconvenient, depending on "set
> breakpoint pending".
> This patch makes use of the new "with" command to save breakpoints
> such that they will automatically be made pending, if necessary, when
> being restored.
> Unfortunately, reloading a breakpoint saved this way will also print:
>     No symbol table is loaded.  Use the "file" command.
> This seems strange to me, and also a bit useless, but changing
> create_breakpoint not to call exception_print in the AUTO_BOOLEAN_TRUE
> case caused other regressions, so I've left it as-is for the time
> being.
> Bug:
> I've tried this out and I think it's very convenient and makes gdb more
user friendly.

Before this patch:
gdb]$ ./gdb -ex 'b write' /bin/ls
save breakpoints tbb

The pending breakpoint was not reloaded:
gdb]$ ./gdb /bin/ls
(gdb) source tbb
Function "write" not defined.
Make breakpoint pending on future shared library load? (y or [n]) [answered
N; input not from terminal]

and after applying the patch pending breakpoint is there:
(gdb) source tbb
Function "write" not defined.
Breakpoint 1 (write) pending.

  reply	other threads:[~2023-01-31 15:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-29 16:21 [PATCH 0/5] Additions to "save" command Tom Tromey
2023-01-29 16:21 ` [PATCH 1/5] Save breakpoints so they are automatically pending Tom Tromey
2023-01-31 15:14   ` Alexandra Petlanova Hajkova [this message]
2023-01-29 16:21 ` [PATCH 2/5] Move show_user_1 to cli-cmds.c Tom Tromey
2023-01-29 16:21 ` [PATCH 3/5] Add "save user" command Tom Tromey
2023-01-29 16:57   ` Eli Zaretskii
2023-01-30 14:53   ` Pedro Alves
2023-01-30 23:35     ` Tom Tromey
2023-01-29 16:21 ` [PATCH 4/5] Add "save skip" command Tom Tromey
2023-01-29 16:54   ` Eli Zaretskii
2023-01-29 16:21 ` [PATCH 5/5] Add "save history" command Tom Tromey
2023-01-29 16:56   ` Eli Zaretskii
2023-01-30 14:50   ` Pedro Alves
2023-01-30 15:12     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).