From: Christopher Di Bella <cjdb@google.com>
To: Simon Marchi <simark@simark.ca>
Cc: gdb-patches@sourceware.org, manojgupta@google.com
Subject: Re: [PATCH] [PATCH] [gdb] adds several headers to the include list
Date: Wed, 20 Jul 2022 08:42:53 -0700 [thread overview]
Message-ID: <CAKCW6pse33gh=eeD18E9S0SBch9BCw7=5u79WHX5MdDof8RHqA@mail.gmail.com> (raw)
In-Reply-To: <ea532650-5fbc-7f01-ae2f-60360ccf1909@simark.ca>
Right, back_inserter's return type is back_insert_iterator and I mixed
the two up. Thanks for correcting it and merging!
On Wed, 20 Jul 2022 at 07:21, Simon Marchi <simark@simark.ca> wrote:
>
>
> On 2022-07-20 02:01, Christopher Di Bella via Gdb-patches wrote:
> > Building GDB currently fails to build with libc++, because libc++ is
> > stricter about which headers "leak" entities they're not guaranteed
> > to support. The following headers have been added:
> >
> > * `<iterator>`, to support `std::back_insert_iterator`
>
> I don't see any use of back_insert_iterator, I guess you mean
> back_inserter.
>
> I pushed the patch with that fixed, thanks.
>
> Simon
>
--
Kind regards,
Christopher Di Bella (he/him/his)
next prev parent reply other threads:[~2022-07-20 15:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 6:01 Christopher Di Bella
2022-07-20 6:04 ` Christopher Di Bella
2022-07-20 14:21 ` Simon Marchi
2022-07-20 15:42 ` Christopher Di Bella [this message]
2022-07-21 17:41 ` Pedro Alves
2022-07-22 18:46 ` Manoj Gupta
2022-07-22 19:26 ` Simon Marchi
2022-07-26 23:45 ` Manoj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKCW6pse33gh=eeD18E9S0SBch9BCw7=5u79WHX5MdDof8RHqA@mail.gmail.com' \
--to=cjdb@google.com \
--cc=gdb-patches@sourceware.org \
--cc=manojgupta@google.com \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).