public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Christopher Di Bella <cjdb@google.com>
To: gdb-patches@sourceware.org
Cc: manojgupta@google.com, Enze Li <enze.li@hotmail.com>,
	simark@simark.ca,  aburgess@redhat.com
Subject: Re: [PATCH] [PATCH] [gdb] adds several headers to the include list
Date: Tue, 19 Jul 2022 23:04:11 -0700	[thread overview]
Message-ID: <CAKCW6pvmVGFQrjuHgJW2DtuLPxMrDhG-GXd51AaLzjL_s9OuWA@mail.gmail.com> (raw)
In-Reply-To: <20220720060120.1250880-1-cjdb@google.com>

This is an updated version of '[PATCH] [PATCH] [gdb] adds several headers
to the include list'.

On Tue, 19 Jul 2022 at 23:01, Christopher Di Bella <cjdb@google.com> wrote:

> Building GDB currently fails to build with libc++, because libc++ is
> stricter about which headers "leak" entities they're not guaranteed
> to support. The following headers have been added:
>
> * `<iterator>`, to support `std::back_insert_iterator`
> * `<utility>`, to support `std::move` and `std::swap`
> * `<vector>`, to support `std::vector`
> ---
>  gdb/value.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/gdb/value.c b/gdb/value.c
> index 022fca91a42..c9bec678d95 100644
> --- a/gdb/value.c
> +++ b/gdb/value.c
> @@ -40,6 +40,9 @@
>  #include "cp-abi.h"
>  #include "user-regs.h"
>  #include <algorithm>
> +#include <iterator>
> +#include <utility>
> +#include <vector>
>  #include "completer.h"
>  #include "gdbsupport/selftest.h"
>  #include "gdbsupport/array-view.h"
> --
> 2.37.0.170.g444d1eabd0-goog
>
>

-- 
Kind regards,

Christopher Di Bella (he/him/his)

  reply	other threads:[~2022-07-20  6:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-20  6:01 Christopher Di Bella
2022-07-20  6:04 ` Christopher Di Bella [this message]
2022-07-20 14:21 ` Simon Marchi
2022-07-20 15:42   ` Christopher Di Bella
2022-07-21 17:41     ` Pedro Alves
2022-07-22 18:46       ` Manoj Gupta
2022-07-22 19:26         ` Simon Marchi
2022-07-26 23:45           ` Manoj Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKCW6pvmVGFQrjuHgJW2DtuLPxMrDhG-GXd51AaLzjL_s9OuWA@mail.gmail.com \
    --to=cjdb@google.com \
    --cc=aburgess@redhat.com \
    --cc=enze.li@hotmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=manojgupta@google.com \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).