From: Pedro Alves <pedro@palves.net>
To: Christopher Di Bella <cjdb@google.com>, Simon Marchi <simark@simark.ca>
Cc: manojgupta@google.com, gdb-patches@sourceware.org
Subject: Re: [PATCH] [PATCH] [gdb] adds several headers to the include list
Date: Thu, 21 Jul 2022 18:41:34 +0100 [thread overview]
Message-ID: <145f7f34-6558-bd0d-7e74-a7183332c196@palves.net> (raw)
In-Reply-To: <CAKCW6pse33gh=eeD18E9S0SBch9BCw7=5u79WHX5MdDof8RHqA@mail.gmail.com>
> diff --git a/gdb/value.c b/gdb/value.c
> index 022fca91a42..c9bec678d95 100644
> --- a/gdb/value.c
> +++ b/gdb/value.c
> @@ -40,6 +40,9 @@
> #include "cp-abi.h"
> #include "user-regs.h"
> #include <algorithm>
> +#include <iterator>
> +#include <utility>
> +#include <vector>
It seems to me that <vector> should have beeen included in the header (value.h):
$ grep std::vector value.h
std::vector<value_ref_ptr> *val_chain,
extern std::vector<value_ref_ptr> value_release_to_mark
next prev parent reply other threads:[~2022-07-21 17:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 6:01 Christopher Di Bella
2022-07-20 6:04 ` Christopher Di Bella
2022-07-20 14:21 ` Simon Marchi
2022-07-20 15:42 ` Christopher Di Bella
2022-07-21 17:41 ` Pedro Alves [this message]
2022-07-22 18:46 ` Manoj Gupta
2022-07-22 19:26 ` Simon Marchi
2022-07-26 23:45 ` Manoj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=145f7f34-6558-bd0d-7e74-a7183332c196@palves.net \
--to=pedro@palves.net \
--cc=cjdb@google.com \
--cc=gdb-patches@sourceware.org \
--cc=manojgupta@google.com \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).