From: "H.J. Lu" <hjl.tools@gmail.com>
To: "Willgerodt, Felix" <felix.willgerodt@intel.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2] gdb: Add XMM16-XMM31 and K0-K1 DWARF register number mapping
Date: Wed, 21 Feb 2024 13:21:08 -0800 [thread overview]
Message-ID: <CAMe9rOpdpXGTFvju2Efo4P3q+=+ucGnjCM6DyrVaG5aT7eMvZg@mail.gmail.com> (raw)
In-Reply-To: <MN2PR11MB4566AD60B0C3424B12D348B48E572@MN2PR11MB4566.namprd11.prod.outlook.com>
On Wed, Feb 21, 2024 at 12:33 AM Willgerodt, Felix
<felix.willgerodt@intel.com> wrote:
>
> > -----Original Message-----
> > From: H.J. Lu <hjl.tools@gmail.com>
> > Sent: Mittwoch, 14. Februar 2024 16:40
> > To: gdb-patches@sourceware.org
> > Cc: Willgerodt, Felix <felix.willgerodt@intel.com>
> > Subject: [PATCH v2] gdb: Add XMM16-XMM31 and K0-K1 DWARF register number
> > mapping
> >
> > Changes in v2:
> >
> > 1. Remove UTF-8 encoding.
> >
> > ---
> > Add XMM16-XMM31 and K0-K1 DWARF register number mapping to
> > amd64_dwarf_regmap.
> > ---
> > gdb/amd64-tdep.c | 23 ++++++++++++++++++++++-
> > 1 file changed, 22 insertions(+), 1 deletion(-)
> >
> > diff --git a/gdb/amd64-tdep.c b/gdb/amd64-tdep.c
> > index a8ff9246b8a..b6ff1c67a86 100644
> > --- a/gdb/amd64-tdep.c
> > +++ b/gdb/amd64-tdep.c
> > @@ -235,7 +235,28 @@ static int amd64_dwarf_regmap[] =
> > /* Floating Point Control Registers. */
> > AMD64_MXCSR_REGNUM,
> > AMD64_FCTRL_REGNUM,
> > - AMD64_FSTAT_REGNUM
> > + AMD64_FSTAT_REGNUM,
> > +
> > + /* XMM16-XMM31. */
> > + AMD64_XMM16_REGNUM + 0, AMD64_XMM16_REGNUM + 1,
> > + AMD64_XMM16_REGNUM + 2, AMD64_XMM16_REGNUM + 3,
> > + AMD64_XMM16_REGNUM + 4, AMD64_XMM16_REGNUM + 5,
> > + AMD64_XMM16_REGNUM + 6, AMD64_XMM16_REGNUM + 7,
> > + AMD64_XMM16_REGNUM + 8, AMD64_XMM16_REGNUM + 9,
> > + AMD64_XMM16_REGNUM + 10, AMD64_XMM16_REGNUM + 11,
> > + AMD64_XMM16_REGNUM + 12, AMD64_XMM16_REGNUM + 13,
> > + AMD64_XMM16_REGNUM + 14, AMD64_XMM16_REGNUM + 15,
> > +
> > + /* Reserved. */
> > + -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1,
> > + -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1,
> > + -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1,
> > +
> > + /* Mask Registers. */
> > + AMD64_K0_REGNUM + 0, AMD64_K0_REGNUM + 1,
> > + AMD64_K0_REGNUM + 2, AMD64_K0_REGNUM + 3,
> > + AMD64_K0_REGNUM + 4, AMD64_K0_REGNUM + 5,
> > + AMD64_K0_REGNUM + 6, AMD64_K0_REGNUM + 7
> > };
> >
> > static const int amd64_dwarf_regmap_len =
> > --
> > 2.43.0
>
>
> While I can't approve, this looks good to me.
>
> Reviewed-By: Felix Willgerodt <felix.willgerodt@intel.com>
>
Who can approve this patch?
Thanks.
--
H.J.
next prev parent reply other threads:[~2024-02-21 21:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 15:40 H.J. Lu
2024-02-21 8:33 ` Willgerodt, Felix
2024-02-21 21:21 ` H.J. Lu [this message]
2024-02-22 10:53 ` Willgerodt, Felix
2024-02-22 14:45 ` PING: " H.J. Lu
2024-02-23 0:36 ` John Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOpdpXGTFvju2Efo4P3q+=+ucGnjCM6DyrVaG5aT7eMvZg@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=felix.willgerodt@intel.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).