[PATCH] gdb/gcore.in - Redirect error messages to stderr

[PATCH] gdb/gcore.in - Redirect error messages to stderr

[Akbarkhon Variskhanov]

--- gdb_gcore.in 2022-03-06 14:47:51.724033755 +0500
+++ gcore.in.patch 2022-03-06 14:56:11.243630494 +0500
@@ -41,7 +41,8 @@
             prefix=$OPTARG
             ;;
         *)
-            echo "usage:  @GCORE_TRANSFORM_NAME@ [-a] [-o prefix] pid1
[pid2...pidN]"
+            echo >&2 "usage:  @GCORE_TRANSFORM_NAME@ [-a] [-o prefix] pid1
\
+             [pid2...pidN]"
             exit 2
             ;;
     esac
@@ -51,7 +52,7 @@

 if [ "$#" -eq "0" ]
 then
-    echo "usage:  @GCORE_TRANSFORM_NAME@ [-a] [-o prefix] pid1
[pid2...pidN]"
+    echo >&2 "usage:  @GCORE_TRANSFORM_NAME@ [-a] [-o prefix] pid1
[pid2...pidN]"
     exit 2
 fi

@@ -85,7 +86,7 @@
 # Check if the GDB binary is in the expected path.  If not, just
 # quit with a message.
 if [ ! -f "$binary_path/@GDB_TRANSFORM_NAME@" ]; then
-  echo "gcore: GDB binary (${binary_path}/@GDB_TRANSFORM_NAME@) not found"
+  echo >&2 "gcore: GDB binary (${binary_path}/@GDB_TRANSFORM_NAME@) not
found"
   exit 1
 fi

@@ -106,7 +107,7 @@
  if [ -r "$prefix.$pid" ] ; then
     rc=0
  else
-    echo "@GCORE_TRANSFORM_NAME@: failed to create $prefix.$pid"
+    echo >&2 "@GCORE_TRANSFORM_NAME@: failed to create $prefix.$pid"
     rc=1
     break
  fi

Re: [PATCH] gdb/gcore.in - Redirect error messages to stderr

[Tom Tromey]

>>>>> Akbarkhon Variskhanov via Gdb-patches <gdb-patches@sourceware.org> writes:

Hi.  Thank you for the patch.

It's customary to put some text in the commit message, not just in the
title.  I suppose it's fine to reword the title and use that.

>  then
> -    echo "usage:  @GCORE_TRANSFORM_NAME@ [-a] [-o prefix] pid1
> [pid2...pidN]"
> +    echo >&2 "usage:  @GCORE_TRANSFORM_NAME@ [-a] [-o prefix] pid1
> [pid2...pidN]"
>      exit 2

It looks like something mangled the email in transmission.

Tom