From: "Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>
To: Pedro Alves <pedro@palves.net>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH 10/12] gdb_target_is_remote -> gdb_protocol_is_remote
Date: Wed, 24 Apr 2024 13:48:09 +0000 [thread overview]
Message-ID: <DM4PR11MB7303B5AF0474296D7FF3AE1AC4102@DM4PR11MB7303.namprd11.prod.outlook.com> (raw)
In-Reply-To: <8248b763-2325-4f9a-86d3-6e8ce7117290@palves.net>
On Tuesday, April 23, 2024 2:47 PM, Pedro Alves wrote:
> >> +# Returns true if gdb_protocol is either "remote" or
> >> +# "extended-remote".
> >> +
> >> +proc gdb_protocol_is_remote { } {
> >> + return [expr {[target_info gdb_protocol] == "remote"
> >> + || [target_info gdb_protocol] == "extended-remote"}]
> >> +}
> >> +
> >
> > How about using `eq`, since this is string comparison? Also in the previous
> > patch in the comparison against "".
>
> I just find that == reads a little bit better. There is no risk
> that this ends up doing a numerical comparison, which would be the reason to
> use string eq. Note that we use == when comparing with gdb_protocol pretty
> much everywhere throughout the testsuite.
I also think `==` is more readable than `eq`. As a background motivation of my
question, I was actually seeking if there is a coding rule about the use of ==
vs eq in the testsuite. Thanks for clarifying!
-Baris
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2024-04-24 13:48 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 15:13 [PATCH 00/12] Fix attach/run failure handling - gdbserver & Windows, document "E.MESSAGE" RSP errors, more Pedro Alves
2024-04-19 15:13 ` [PATCH 01/12] Document conventions for describing packet syntax Pedro Alves
2024-04-19 15:25 ` Eli Zaretskii
2024-04-19 15:42 ` Eli Zaretskii
2024-04-22 19:10 ` Pedro Alves
2024-04-22 19:01 ` Pedro Alves
2024-04-22 19:44 ` Eli Zaretskii
2024-04-19 15:13 ` [PATCH 02/12] Centralize documentation of error and empty RSP responses Pedro Alves
2024-04-19 15:36 ` Eli Zaretskii
2024-04-19 15:42 ` Eli Zaretskii
2024-04-22 19:00 ` Pedro Alves
2024-04-22 19:42 ` Eli Zaretskii
2024-04-19 15:13 ` [PATCH 03/12] Document "E.MESSAGE" RSP errors Pedro Alves
2024-04-19 15:37 ` Eli Zaretskii
2024-04-22 8:50 ` Andrew Burgess
2024-04-22 19:04 ` Pedro Alves
2024-04-26 19:02 ` Pedro Alves
2024-04-26 19:18 ` Eli Zaretskii
2024-04-29 13:42 ` Andrew Burgess
2024-04-19 15:13 ` [PATCH 04/12] Windows: Fix run/attach hang after bad run/attach Pedro Alves
2024-04-19 18:35 ` Tom Tromey
2024-04-19 15:13 ` [PATCH 05/12] Fix "run" failure handling with GDBserver Pedro Alves
2024-04-19 18:41 ` Tom Tromey
2024-04-19 15:13 ` [PATCH 06/12] Improve vRun error reporting Pedro Alves
2024-04-19 18:43 ` Tom Tromey
2024-04-22 11:32 ` Alexandra Petlanova Hajkova
2024-04-19 15:13 ` [PATCH 07/12] Fix "attach" failure handling with GDBserver Pedro Alves
2024-04-19 18:47 ` Tom Tromey
2024-04-19 15:13 ` [PATCH 08/12] gdbserver: Fix vAttach response when attaching is not supported Pedro Alves
2024-04-19 18:48 ` Tom Tromey
2024-04-19 15:13 ` [PATCH 09/12] gdb_target_is_native -> gdb_protocol_is_native Pedro Alves
2024-04-19 18:50 ` Tom Tromey
2024-05-09 8:47 ` Bernd Edlinger
2024-05-09 9:47 ` Pedro Alves
2024-05-09 11:54 ` Bernd Edlinger
2024-05-09 12:05 ` Pedro Alves
2024-05-09 13:19 ` Bernd Edlinger
2024-05-09 13:31 ` Pedro Alves
2024-05-09 15:01 ` Bernd Edlinger
2024-05-09 15:49 ` Pedro Alves
2024-05-09 18:44 ` Bernd Edlinger
2024-05-10 10:52 ` [pushed] gdb sim testing, set gdb_protocol to "sim" Pedro Alves
2024-04-22 8:25 ` [PATCH 09/12] gdb_target_is_native -> gdb_protocol_is_native Aktemur, Tankut Baris
2024-04-23 12:33 ` Pedro Alves
2024-04-19 15:13 ` [PATCH 10/12] gdb_target_is_remote -> gdb_protocol_is_remote Pedro Alves
2024-04-19 18:56 ` Tom Tromey
2024-04-23 12:30 ` Pedro Alves
2024-04-22 8:30 ` Aktemur, Tankut Baris
2024-04-23 12:47 ` Pedro Alves
2024-04-24 13:48 ` Aktemur, Tankut Baris [this message]
2024-04-19 15:13 ` [PATCH 11/12] Eliminate gdb_is_target_remote / gdb_is_target_native & friends Pedro Alves
2024-04-19 18:57 ` Tom Tromey
2024-04-19 15:13 ` [PATCH 12/12] Fix gdb.base/attach.exp --pid test skipping on native-extended-gdbserver Pedro Alves
2024-04-19 18:59 ` Tom Tromey
2024-04-26 20:25 ` [PATCH 00/12] Fix attach/run failure handling - gdbserver & Windows, document "E.MESSAGE" RSP errors, more Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB7303B5AF0474296D7FF3AE1AC4102@DM4PR11MB7303.namprd11.prod.outlook.com \
--to=tankut.baris.aktemur@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).