Re: [PATCH 09/12] gdb_target_is_native -> gdb_protocol_is_native

[Bernd Edlinger <bernd.edlinger@hotmail.de>]

On 4/19/24 20:50, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:
> 
> Pedro> gdb_is_target_native uses "maint print target-stack", which is
> Pedro> unnecessary when checking whether gdb_protocol is empty would do.
> Pedro> Checking gdb_protocol is more efficient, and can be done before
> Pedro> starting GDB and running to main, unlike gdb_is_target_native.
> 
> Pedro> This adds a new gdb_protocol_is_native procedure, and uses it in place
> Pedro> of gdb_is_target_native.
> 
> Pedro> At first, I thought that we'd end up with a few testcases needing to
> Pedro> use gdb_is_target_native still, especially multi-target tests that
> Pedro> connect to targets different from the default board target, but no,
> Pedro> actually all uses of gdb_is_target_native could be converted.
> Pedro> gdb_is_target_native will be eliminated in a following patch.
> 
> Pedro> In some spots, we no longer need to defer the check until after
> Pedro> starting GDB, so the patch adjusts accordingly.
> 
> Seems reasonable to me.
> Approved-By: Tom Tromey <tom@tromey.com>
> 
> Tom
> 

Hi Pedro,

Sorry, for the late reply.

I am testing with riscv-unknown-elf target using simulator.
Before this patch I had:

PASS: gdb.base/load-command.exp: probe for target native
PASS: gdb.base/load-command.exp: check initial value of the_variable
PASS: gdb.base/load-command.exp: manually change the_variable
PASS: gdb.base/load-command.exp: check manually changed value of the_variable
PASS: gdb.base/load-command.exp: reload: re-load binary
PASS: gdb.base/load-command.exp: reload: check initial value of the_variable

and now

UNSUPPORTED: gdb.base/load-command.exp: the native target does not support the load command

note: I use RUNTESTFLAGS="--target_board=multi-sim SIM=riscv-unknown-elf-sim"
but the test was working fine, because with this target
we use target sim, load, and can runto main, inspect variables, etc.


Regards
Bernd.