From: "Terekhov, Mikhail" <Mikhail.Terekhov@dell.com>
To: Simon Marchi <simon.marchi@polymtl.ca>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH 0/3] Add assertion when marking the remote async flag
Date: Fri, 6 Oct 2023 21:28:39 +0000 [thread overview]
Message-ID: <DM5PR1901MB21502DEB6CA14A61F2328DF7E5C9A@DM5PR1901MB2150.namprd19.prod.outlook.com> (raw)
In-Reply-To: <20231004020701.260411-1-simon.marchi@polymtl.ca>
> -----Original Message-----
> From: Gdb-patches <gdb-patches-
> bounces+mikhail.terekhov=dell.com@sourceware.org> On Behalf Of Simon
> Marchi via Gdb-patches
> Sent: Tuesday, October 3, 2023 10:04 PM
> To: gdb-patches@sourceware.org
> Cc: Simon Marchi <simon.marchi@polymtl.ca>
> Subject: [PATCH 0/3] Add assertion when marking the remote async flag
>
> I had this idea while reviewing this patch [1]. When marking the remote
> async flag, assert that the target is actually in async mode, instead of relying
> on an assert that comes at a later time, in the wait method.
After applying this series GDB fails in my setup in assert in mark_async_event_handler
right after call to it from queued_stop_reply. See my comment to PATCH 3/3.
> The first two patches are small preparatory refactorings, and the third one
> adds the assertion.
>
> [1] https://urldefense.com/v3/__https://inbox.sourceware.org/gdb-
> patches/3d728a6e-1cb0-49c2-a4c8-
> 0a974be39fee@simark.ca/T/*ma1903117423ae09c3574fd45ade2dd4af528063
> 3__;Iw!!LpKI!kBSMETr5QzzmvTDT4A0kxAcpgnOpWd2ZyualTzxDwp42So5Om
> byWvIb9bglZjsO4OCDKV_fIXMUj-
> Yh5Q6PUPj26WV9J$ [inbox[.]sourceware[.]org]
>
> Simon Marchi (3):
> gdb: make remote_state's async token private
> gdb: add remote_state::{is_async_p,can_async_p}
> gdb: add assertion when marking the remote async flag
>
> gdb/remote.c | 93 ++++++++++++++++++++++++++++++++++----------------
> --
> 1 file changed, 62 insertions(+), 31 deletions(-)
>
>
> base-commit: 1181bcd0d2572aee2c0947040e56bc1f9af634e3
> --
> 2.42.0
Internal Use - Confidential
prev parent reply other threads:[~2023-10-06 21:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 2:03 Simon Marchi
2023-10-04 2:03 ` [PATCH 1/3] gdb: make remote_state's async token private Simon Marchi
2023-10-09 9:11 ` Andrew Burgess
2023-10-10 14:56 ` Simon Marchi
2023-10-04 2:04 ` [PATCH 2/3] gdb: add remote_state::{is_async_p,can_async_p} Simon Marchi
2023-10-09 9:20 ` Andrew Burgess
2023-10-10 15:01 ` Simon Marchi
2023-10-04 2:04 ` [PATCH 3/3] gdb: add assertion when marking the remote async flag Simon Marchi
2023-10-06 21:09 ` Terekhov, Mikhail
2023-10-07 1:35 ` Simon Marchi
2023-10-09 9:25 ` Andrew Burgess
2023-10-10 15:01 ` Simon Marchi
2023-10-06 21:28 ` Terekhov, Mikhail [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR1901MB21502DEB6CA14A61F2328DF7E5C9A@DM5PR1901MB2150.namprd19.prod.outlook.com \
--to=mikhail.terekhov@dell.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).