From: "Metzger, Markus T" <markus.t.metzger@intel.com>
To: "Willgerodt, Felix" <felix.willgerodt@intel.com>,
"Eli Zaretskii (eliz@gnu.org)" <eliz@gnu.org>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH v5 02/10] btrace: Enable auxiliary instructions in record instruction-history.
Date: Wed, 29 Jun 2022 10:43:00 +0000 [thread overview]
Message-ID: <DM8PR11MB57496142B786A81775D13219DEBB9@DM8PR11MB5749.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MN2PR11MB4566CE04656D5FCD70A9B69A8EB89@MN2PR11MB4566.namprd11.prod.outlook.com>
Hello Felix,
>> >Print the auxiliary data when a btrace_insn of type BTRACE_INSN_AUX
>> >is encountered in the instruction-history. Printing is active by default,
>> >it can be silenced with the /a modifier.
>>
>> I find it a bit strange that /a disables some output instead of enabling it.
>> Should we change the default? I'd probably always use it, but then, I
>> also always supply /cli to 'record function-call-history'.
>
>I don't find it strange. /p and /f already disables some output:
>
>(gdb) help record instruction-history
>Print disassembled instructions stored in the execution log.
>With a /m or /s modifier, source lines are included (if available).
>With a /r modifier, raw instructions in hex are included.
>With a /f modifier, function names are omitted.
>With a /p modifier, current position markers are omitted.
>
>I think we should make the default the thing GDB users "would want".
Hmmm, OK, it does fit. /p was added later so I had to make it omit things
to preserve backwards compatibility. But /f was there from the beginning.
I'm OK either way; let's hear what Eli thinks.
>> >+ else if (insn->iclass == BTRACE_INSN_AUX)
>> >+ {
>> >+ if ((flags & DISASSEMBLY_OMIT_AUX_INSN) != 0)
>> >+ continue;
>> >+
>> >+ uiout->field_fmt ("insn-number", "%u", btrace_insn_number (&it));
>> >+ uiout->text ("\t");
>> >+ uiout->spaces (3);
>> >+ uiout->text ("[");
>> >+ uiout->field_fmt (
>> >+ "aux-data", "%s",
>> >+ it.btinfo->aux_data.at (insn->aux_data_index).c_str ());
>>
>> The formatting is a bit unusual.
>
>Agreed. How should I format it instead? The last line is the problem.
>
>Should it be this:
>
> uiout->field_fmt
> ("aux-data", "%s",
> it.btinfo->aux_data.at (insn->aux_data_index).c_str ());
>
>Or should it be something like this:
>
> uiout->field_fmt ("aux-data", "%s",
> it.btinfo->aux_data.at
> (insn->aux_data_index).c_str ());
>
>Or I can also add a temporary std:string:
>
> std::string data
> = it.btinfo->aux_data.at (insn->aux_data_index).c_str ();
> uiout->field_fmt ("aux-data", "%s", data);
No need to construct a std::string; you may just use a const char * or
a reference to the std::string that at () returns.
All of the above are acceptable, I think.
regards,
markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2022-06-29 10:43 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 11:43 [PATCH v5 00/10] Extensions for PTWRITE Felix Willgerodt
2022-06-22 11:43 ` [PATCH v5 01/10] btrace: Introduce auxiliary instructions Felix Willgerodt
2022-06-28 9:10 ` Metzger, Markus T
2022-06-22 11:43 ` [PATCH v5 02/10] btrace: Enable auxiliary instructions in record instruction-history Felix Willgerodt
2022-06-28 9:10 ` Metzger, Markus T
2022-06-28 11:28 ` Willgerodt, Felix
2022-06-29 10:43 ` Metzger, Markus T [this message]
2022-06-22 11:43 ` [PATCH v5 03/10] btrace: Enable auxiliary instructions in record function-call-history Felix Willgerodt
2022-06-28 9:10 ` Metzger, Markus T
2022-09-19 8:59 ` Willgerodt, Felix
2022-06-22 11:43 ` [PATCH v5 04/10] btrace: Handle stepping and goto for auxiliary instructions Felix Willgerodt
2022-06-28 9:11 ` Metzger, Markus T
2022-06-22 11:43 ` [PATCH v5 05/10] python: Introduce gdb.RecordAuxiliary class Felix Willgerodt
2022-06-28 9:11 ` Metzger, Markus T
2022-07-11 12:48 ` Willgerodt, Felix
2022-06-22 11:43 ` [PATCH v5 06/10] python: Add clear() to gdb.Record Felix Willgerodt
2022-06-28 9:11 ` Metzger, Markus T
2022-06-22 11:43 ` [PATCH v5 07/10] btrace, gdbserver: Add ptwrite to btrace_config_pt Felix Willgerodt
2022-06-28 9:11 ` Metzger, Markus T
2022-06-22 11:43 ` [PATCH v5 08/10] btrace, linux: Enable ptwrite packets Felix Willgerodt
2022-06-28 9:12 ` Metzger, Markus T
2022-06-22 11:43 ` [PATCH v5 09/10] btrace, python: Enable ptwrite filter registration Felix Willgerodt
2022-06-28 13:59 ` Metzger, Markus T
2022-07-11 12:48 ` Willgerodt, Felix
2022-07-12 12:23 ` Metzger, Markus T
2022-07-13 8:49 ` Willgerodt, Felix
2022-07-13 15:20 ` Metzger, Markus T
2022-07-26 14:08 ` Willgerodt, Felix
2022-09-14 8:37 ` Metzger, Markus T
2022-06-22 11:43 ` [PATCH v5 10/10] btrace: Extend ptwrite event decoding Felix Willgerodt
2022-06-29 13:35 ` Metzger, Markus T
2022-09-19 8:59 ` Willgerodt, Felix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8PR11MB57496142B786A81775D13219DEBB9@DM8PR11MB5749.namprd11.prod.outlook.com \
--to=markus.t.metzger@intel.com \
--cc=eliz@gnu.org \
--cc=felix.willgerodt@intel.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).