RE: [PATCH v5 02/10] btrace: Enable auxiliary instructions in record instruction-history.

["Metzger, Markus T" <markus.t.metzger@intel.com>]

Hello Felix,

>Print the auxiliary data when a btrace_insn of type BTRACE_INSN_AUX
>is encountered in the instruction-history.  Printing is active by default,
>it can be silenced with the /a modifier.

I find it a bit strange that /a disables some output instead of enabling it.
Should we change the default?  I'd probably always use it, but then, I
also always supply /cli to 'record function-call-history'.


>This patch is in preparation for the new ptwrite feature, which is based on
>auxiliary instructions.
>---
> gdb/disasm-flags.h  |  1 +
> gdb/doc/gdb.texinfo |  3 +++
> gdb/record-btrace.c | 14 ++++++++++++++
> gdb/record.c        |  5 +++++
> 4 files changed, 23 insertions(+)

>+      else if (insn->iclass == BTRACE_INSN_AUX)
>+	{
>+	  if ((flags & DISASSEMBLY_OMIT_AUX_INSN) != 0)
>+	    continue;
>+
>+	  uiout->field_fmt ("insn-number", "%u", btrace_insn_number (&it));
>+	  uiout->text ("\t");
>+	  uiout->spaces (3);
>+	  uiout->text ("[");
>+	  uiout->field_fmt (
>+	      "aux-data", "%s",
>+	      it.btinfo->aux_data.at (insn->aux_data_index).c_str ());

The formatting is a bit unusual.

regards,
markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928