RE: [PATCH v5 04/10] btrace: Handle stepping and goto for auxiliary instructions.

["Metzger, Markus T" <markus.t.metzger@intel.com>]

Hello Felix,

>Print the auxiliary data when stepping. Don't allow to goto an auxiliary
>instruction.
>
>This patch is in preparation for the new ptwrite feature, which is based on
>auxiliary instructions.
>---
> gdb/record-btrace.c | 68 ++++++++++++++++++++++++++++++++++++---------
> 1 file changed, 55 insertions(+), 13 deletions(-)

LGTM.


>+  const struct btrace_insn *insn = btrace_insn_get (&it);
>+
>+  if ((insn == NULL) || (insn->iclass == BTRACE_INSN_AUX))
>     error (_("No such instruction."));

Let's remove the empty line between those two statements to group them.

thanks,
markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928