From: "Metzger, Markus T" <markus.t.metzger@intel.com>
To: Tom Tromey <tom@tromey.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH 22/46] Use require skip_btrace_tests
Date: Sat, 17 Dec 2022 09:22:47 +0000 [thread overview]
Message-ID: <DM8PR11MB57496F87A84F453440A385A1DEE79@DM8PR11MB5749.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221217000818.3729389-23-tom@tromey.com>
>This changes some tests to use "require skip_btrace_tests".
>---
> gdb/testsuite/gdb.btrace/buffer-size.exp | 5 +----
> gdb/testsuite/gdb.btrace/data.exp | 5 +----
> gdb/testsuite/gdb.btrace/delta.exp | 5 +----
> gdb/testsuite/gdb.btrace/enable-new-thread.exp | 5 +----
> gdb/testsuite/gdb.btrace/enable-running.exp | 5 +----
> gdb/testsuite/gdb.btrace/enable.exp | 5 +----
> gdb/testsuite/gdb.btrace/exception.exp | 5 +----
> gdb/testsuite/gdb.btrace/function_call_history.exp | 5 +----
> gdb/testsuite/gdb.btrace/gcore.exp | 5 +----
> gdb/testsuite/gdb.btrace/instruction_history.exp | 5 +----
> gdb/testsuite/gdb.btrace/multi-inferior.exp | 5 +----
> gdb/testsuite/gdb.btrace/multi-thread-step.exp | 5 +----
> gdb/testsuite/gdb.btrace/nohist.exp | 5 +----
> gdb/testsuite/gdb.btrace/non-stop.exp | 5 +----
> gdb/testsuite/gdb.btrace/reconnect.exp | 5 +----
> gdb/testsuite/gdb.btrace/record_goto-step.exp | 5 +----
> gdb/testsuite/gdb.btrace/record_goto.exp | 5 +----
> gdb/testsuite/gdb.btrace/rn-dl-bind.exp | 5 +----
> gdb/testsuite/gdb.btrace/segv.exp | 5 +----
> gdb/testsuite/gdb.btrace/step.exp | 5 +----
> gdb/testsuite/gdb.btrace/stepi.exp | 5 +----
> gdb/testsuite/gdb.btrace/tailcall-only.exp | 5 +----
> gdb/testsuite/gdb.btrace/tailcall.exp | 5 +----
> gdb/testsuite/gdb.btrace/unknown_functions.exp | 5 +----
> gdb/testsuite/gdb.btrace/vdso.exp | 5 +----
> gdb/testsuite/gdb.python/py-record-btrace-threads.exp | 5 +----
> gdb/testsuite/gdb.python/py-record-btrace.exp | 5 +----
> 27 files changed, 27 insertions(+), 108 deletions(-)
LGTM with two nits and a general comment below.
>-if { [skip_btrace_tests] } {
>- unsupported "target does not support record-btrace"
>- return -1
>-}
>+require !skip_btrace_tests
This looks a little bit odd, now, and the ! is easy to miss. Those skip checks
should probably be rewritten as support checks to fit better into the new
require logic.
>-if { [skip_btrace_tests] } {
>- unsupported "target does not support record-btrace"
>- return -1
>-}
>+require !skip_btrace_tests
>
> if { [use_gdb_stub] } {
> unsupported "test creates multiple inferiors"
Should this be
require !skip_btrace_tests !use_gdb_stub
>-if { [skip_btrace_tests] } {
>- unsupported "target does not support record-btrace"
>- return -1
>-}
>+require !skip_btrace_tests
> if { [skip_gdbserver_tests] } {
> unsupported "target does not support gdbserver"
> return -1
Same here with skip_gdbserver_tests.
regards,
markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2022-12-17 9:22 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-17 0:07 [PATCH 00/46] Rewrite "require" test procedure and use it more often Tom Tromey
2022-12-17 0:07 ` [PATCH 01/46] Don't use ensure_gdb_index with require Tom Tromey
2022-12-17 0:07 ` [PATCH 02/46] Change 'require' to accept a list of predicates Tom Tromey
2022-12-17 0:07 ` [PATCH 03/46] Use unsupported in 'require' Tom Tromey
2022-12-23 12:39 ` Aktemur, Tankut Baris
2023-01-06 1:14 ` Tom Tromey
2022-12-17 0:07 ` [PATCH 04/46] Use require supports_reverse Tom Tromey
2022-12-17 0:07 ` [PATCH 05/46] Use require supports_process_record Tom Tromey
2022-12-17 0:07 ` [PATCH 06/46] Use require dwarf2_support Tom Tromey
2022-12-17 0:07 ` [PATCH 07/46] Use require is_x86_like_target Tom Tromey
2022-12-17 0:07 ` [PATCH 08/46] Use require skip_cplus_tests Tom Tromey
2022-12-17 0:07 ` [PATCH 09/46] Use require skip_shlib_tests Tom Tromey
2022-12-17 0:07 ` [PATCH 10/46] Use require skip_dlmopen_tests Tom Tromey
2022-12-17 0:07 ` [PATCH 11/46] Use require skip_stl_tests Tom Tromey
2022-12-17 0:07 ` [PATCH 12/46] Use require skip_rust_tests Tom Tromey
2022-12-17 0:07 ` [PATCH 13/46] Use require skip_fortran_tests Tom Tromey
2022-12-17 0:07 ` [PATCH 14/46] Use require skip_ada_tests Tom Tromey
2022-12-17 0:07 ` [PATCH 15/46] Use require skip_go_tests Tom Tromey
2022-12-17 0:07 ` [PATCH 16/46] Use require skip_d_tests Tom Tromey
2022-12-17 0:07 ` [PATCH 17/46] Use require skip_ctf_tests Tom Tromey
2022-12-17 0:07 ` [PATCH 18/46] Use require skip_hw_watchpoint_tests Tom Tromey
2022-12-17 0:07 ` [PATCH 19/46] Use require skip_ifunc_tests Tom Tromey
2022-12-17 0:07 ` [PATCH 20/46] Use require skip_aarch64_sve_tests Tom Tromey
2022-12-19 10:50 ` Luis Machado
2022-12-17 0:07 ` [PATCH 21/46] Use require skip_btrace_tests Tom Tromey
2022-12-17 1:15 ` Enze Li
2022-12-18 0:48 ` Tom Tromey
2022-12-19 5:13 ` Enze Li
2022-12-19 14:44 ` Tom Tromey
2022-12-17 0:07 ` [PATCH 22/46] " Tom Tromey
2022-12-17 9:22 ` Metzger, Markus T [this message]
2022-12-18 17:46 ` Tom Tromey
2022-12-17 0:07 ` [PATCH 23/46] Use require skip_avx_* Tom Tromey
2022-12-17 0:07 ` [PATCH 24/46] Use require support_displaced_stepping Tom Tromey
2022-12-17 0:07 ` [PATCH 25/46] Use require is_aarch64_target Tom Tromey
2022-12-19 10:46 ` Luis Machado
2022-12-17 0:07 ` [PATCH 26/46] Use require is_aarch32_target Tom Tromey
2022-12-19 10:46 ` Luis Machado
2022-12-17 0:07 ` [PATCH 27/46] Use require is_amd64_regs_target Tom Tromey
2022-12-17 0:08 ` [PATCH 28/46] Use require is_elf_target Tom Tromey
2022-12-17 0:08 ` [PATCH 29/46] Use require can_single_step_to_signal_handler Tom Tromey
2022-12-17 0:08 ` [PATCH 30/46] Use require supports_get_siginfo_type Tom Tromey
2022-12-17 0:08 ` [PATCH 31/46] Use require support_go_compile Tom Tromey
2022-12-17 0:08 ` [PATCH 32/46] Use require use_gdb_stub Tom Tromey
2022-12-17 0:08 ` [PATCH 33/46] Use require can_spawn_for_attach Tom Tromey
2022-12-17 0:08 ` [PATCH 34/46] Use require isnative Tom Tromey
2022-12-17 0:08 ` [PATCH 35/46] Use require skip_gdbserver_tests Tom Tromey
2022-12-17 0:08 ` [PATCH 36/46] Use require skip_shlib_tests Tom Tromey
2022-12-17 0:08 ` [PATCH 37/46] Use require is_c_compiler_gcc Tom Tromey
2022-12-17 0:08 ` [PATCH 38/46] Use require gdb_debug_enabled Tom Tromey
2022-12-17 0:08 ` [PATCH 39/46] Use require gdb_skip_xml_test Tom Tromey
2022-12-17 0:08 ` [PATCH 40/46] Use require gdb_trace_common_supports_arch Tom Tromey
2022-12-17 0:08 ` [PATCH 41/46] Use require skip_perf_tests Tom Tromey
2022-12-17 0:08 ` [PATCH 42/46] Use require skip_opencl_tests Tom Tromey
2022-12-17 0:08 ` [PATCH 43/46] Use require target_can_use_run_cmd Tom Tromey
2022-12-17 0:08 ` [PATCH 44/46] Use require using_fission Tom Tromey
2022-12-17 0:08 ` [PATCH 45/46] Use require skip_debuginfod_tests Tom Tromey
2022-12-17 0:08 ` [PATCH 46/46] Use require gnat_runtime_has_debug_info Tom Tromey
2022-12-19 10:49 ` [PATCH 00/46] Rewrite "require" test procedure and use it more often Luis Machado
2023-01-06 2:45 ` Tom Tromey
2023-01-05 1:29 ` Kevin Buettner
2023-01-06 2:47 ` Tom Tromey
2023-01-07 0:07 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8PR11MB57496F87A84F453440A385A1DEE79@DM8PR11MB5749.namprd11.prod.outlook.com \
--to=markus.t.metzger@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).