Re: [PATCH v8 3/3] gdb/python: Export nibbles to python layer

[Enze Li <lienze2010@hotmail.com>]

On Sat, 2022-04-23 at 12:22 +0300, Eli Zaretskii via Gdb-patches wrote:
> > Date: Sat, 23 Apr 2022 17:16:55 +0800
> > From: Enze Li via Gdb-patches <gdb-patches@sourceware.org>
> > Cc: gdb-patches@sourceware.org
> > 
> > diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi
> > index cb5283e03c0..5fd757d4891 100644
> > --- a/gdb/doc/python.texi
> > +++ b/gdb/doc/python.texi
> > @@ -1094,6 +1094,11 @@ union} in @ref{Print Settings}).
> >  address, @code{False} if it shouldn't (see @code{set print
> > address} in
> >  @ref{Print Settings}).
> >  
> > +@item nibbles
> > +@code{True} if binary values should be displayed in groups of four
> > bits,
> > +known as nibbles. @code{False} if it shouldn't (see @code{set
> > print
> > +nibbles} in @ref{Print Settings}).
> 
> The part in parentheses will produce better output if you use @pxref:
> 
>   @code{False} if it shouldn't (@pxref{Print Settings, set print
> nibbles}).
> 
> Also, please leave two spaces between sentences, not one.
> 
> OK with these nits fixed.
> 
> Thanks.

Hi Eli,

I was looking through my drafts, and I realized I never sent this
email.

Thanks for your review.  I have made the changes locally as you pointed
out.

Best Regards,
Enze