From: Enze Li <enze.li@hotmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: tom@tromey.com, gdb-patches@sourceware.org, pedro@palves.net
Subject: Re: [PATCH v8 3/3] gdb/python: Export nibbles to python layer
Date: Tue, 07 Jun 2022 21:44:57 +0800 [thread overview]
Message-ID: <OS3P286MB21529A56578C3413962990B9F0A59@OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <834k2kp31l.fsf@gnu.org>
On Sat, 2022-04-23 at 12:22 +0300, Eli Zaretskii via Gdb-patches wrote:
> > Date: Sat, 23 Apr 2022 17:16:55 +0800
> > From: Enze Li via Gdb-patches <gdb-patches@sourceware.org>
> > Cc: gdb-patches@sourceware.org
> >
> > diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi
> > index cb5283e03c0..5fd757d4891 100644
> > --- a/gdb/doc/python.texi
> > +++ b/gdb/doc/python.texi
> > @@ -1094,6 +1094,11 @@ union} in @ref{Print Settings}).
> > address, @code{False} if it shouldn't (see @code{set print
> > address} in
> > @ref{Print Settings}).
> >
> > +@item nibbles
> > +@code{True} if binary values should be displayed in groups of four
> > bits,
> > +known as nibbles. @code{False} if it shouldn't (see @code{set
> > print
> > +nibbles} in @ref{Print Settings}).
>
> The part in parentheses will produce better output if you use @pxref:
>
> @code{False} if it shouldn't (@pxref{Print Settings, set print
> nibbles}).
>
> Also, please leave two spaces between sentences, not one.
>
> OK with these nits fixed.
>
> Thanks.
Hi Eli,
I was looking through my drafts, and I realized I never sent this
email.
Thanks for your review. I have made the changes locally as you pointed
out.
Best Regards,
Enze
next prev parent reply other threads:[~2022-06-07 13:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-23 9:12 [PING][PATCH v8 0/3] gdb: Add new 'print nibbles' feature Enze Li
2022-04-23 9:14 ` [PATCH v8 1/3] " Enze Li
2022-04-23 9:15 ` [PATCH v8 2/3] gdb/doc: Documentation for the new print command Enze Li
2022-04-23 9:20 ` Eli Zaretskii
2022-04-23 9:16 ` [PATCH v8 3/3] gdb/python: Export nibbles to python layer Enze Li
2022-04-23 9:22 ` Eli Zaretskii
2022-06-07 13:44 ` Enze Li
2022-06-07 13:44 ` Enze Li [this message]
2022-06-06 13:41 ` [PING][PATCH v8 0/3] gdb: Add new 'print nibbles' feature Tom Tromey
2022-06-07 13:29 ` Enze Li
2022-06-18 3:29 ` Enze Li
[not found] <20220416175963.3211-1-lienze2010@hotmail.com>
[not found] ` <20220416181725.7176-1-lienze2010@hotmail.com>
2022-04-16 18:17 ` [PATCH v8 3/3] gdb/python: Export nibbles to python layer Enze Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OS3P286MB21529A56578C3413962990B9F0A59@OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM \
--to=enze.li@hotmail.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).