RE: [PATCH v4 1/4] gdb, dwarf: add support for DW_AT_trampoline in DWARF reader

["Ijaz, Abdul B" <abdul.b.ijaz@intel.com>]

Tom>That is, the attribute references the subprogram DIE directly, so it seems like using the name should not be needed.
Yes right, will use  the address of target subroutine instead of name. Will be updated it in v5.

Thanks & Best Regards
Abdul Basit

-----Original Message-----
From: Tom Tromey <tom@tromey.com> 
Sent: Thursday, August 10, 2023 6:19 PM
To: Ijaz, Abdul B via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tom@tromey.com>; Ijaz, Abdul B <abdul.b.ijaz@intel.com>; JiniSusan.George@amd.com; eliz@gnu.org; blarsen@redhat.com
Subject: Re: [PATCH v4 1/4] gdb, dwarf: add support for DW_AT_trampoline in DWARF reader

Tom> I didn't realize this until starting to read patch 2, but it seems 
Tom> strange to use the name here.  It seems to me it would be better to 
Tom> use the address attached to the referenced subroutine DIE

> For this case of value of attributes for this DIE may contain mangled 
> name of the target. So for such cases we are preferring the linkage 
> name to store. Shouldn't it cover such issues. Otherwise let me know 
> then I may update accordingly.

> As per dwarf spec: "
> If the value is of class string, then the value is the (possibly mangled) name  of the target subprogram.
> "

The case I was referring to is the one where the attribute is a reference to another DIE:

> +      else if (attr->form_is_ref ())

And here, DWARF 5 says:

    If the value is of class reference, then the value specifies the
    debugging information entry of the target subprogram.

That is, the attribute references the subprogram DIE directly, so it seems like using the name should not be needed.

Tom
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928