From: Tom Tromey <tom@tromey.com>
To: "Ijaz, Abdul B via Gdb-patches" <gdb-patches@sourceware.org>
Cc: Tom Tromey <tom@tromey.com>,
"Ijaz, Abdul B" <abdul.b.ijaz@intel.com>,
"JiniSusan.George@amd.com" <JiniSusan.George@amd.com>,
"eliz@gnu.org" <eliz@gnu.org>,
"blarsen@redhat.com" <blarsen@redhat.com>
Subject: Re: [PATCH v4 1/4] gdb, dwarf: add support for DW_AT_trampoline in DWARF reader
Date: Thu, 10 Aug 2023 10:20:47 -0600 [thread overview]
Message-ID: <87msyy3m3k.fsf@tromey.com> (raw)
In-Reply-To: <SA1PR11MB684606ADA1B87FFEA50A45EECB0CA@SA1PR11MB6846.namprd11.prod.outlook.com> (Abdul B. via Gdb-patches Ijaz's message of "Mon, 7 Aug 2023 14:43:01 +0000")
>>>>> Ijaz, Abdul B via Gdb-patches <gdb-patches@sourceware.org> writes:
Abdul> + func_type_flags flags;
Tom> This should use ENUM_BITFIELD like the other spot in the patch.
> This flag may store multiple values together with no return and
> trampoline types for a function. That is the reason why it is used
> like this here. So value is already bitfield like:
Actually I think I misread and thought this was still using a bitfield,
which it is not. So I think that bit is fine.
Tom
next prev parent reply other threads:[~2023-08-10 16:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 22:47 [PATCH v4 0/4] GDB support for DW_AT_trampoline Abdul Basit Ijaz
2023-08-01 22:47 ` [PATCH v4 1/4] gdb, dwarf: add support for DW_AT_trampoline in DWARF reader Abdul Basit Ijaz
2023-08-02 20:07 ` Tom Tromey
2023-08-07 14:43 ` Ijaz, Abdul B
2023-08-10 16:20 ` Tom Tromey [this message]
2023-08-02 20:13 ` Tom Tromey
2023-08-07 13:36 ` Ijaz, Abdul B
2023-08-10 16:18 ` Tom Tromey
2023-08-14 21:53 ` Ijaz, Abdul B
2023-08-01 22:47 ` [PATCH v4 2/4] gdb/symtab: add lookup for trampoline functions Abdul Basit Ijaz
2023-08-02 20:18 ` Tom Tromey
2023-08-07 7:40 ` Ijaz, Abdul B
2023-08-01 22:47 ` [PATCH v4 3/4] gdb/infrun: handle stepping through functions with DW_AT_trampoline Abdul Basit Ijaz
2023-08-02 11:52 ` Eli Zaretskii
2023-08-02 11:54 ` Ijaz, Abdul B
2023-08-02 20:33 ` Tom Tromey
2023-08-07 8:08 ` Ijaz, Abdul B
2023-08-10 16:56 ` Tom Tromey
2023-08-16 14:18 ` Ijaz, Abdul B
2023-08-01 22:47 ` [PATCH v4 4/4] gdb: Skip trampoline frames in the stack for printing or finish command Abdul Basit Ijaz
2023-08-02 11:52 ` Eli Zaretskii
2023-08-02 11:54 ` Ijaz, Abdul B
2023-08-02 20:41 ` Tom Tromey
2023-08-07 13:28 ` Ijaz, Abdul B
2023-08-10 17:45 ` Tom Tromey
2023-08-02 20:42 ` Tom Tromey
2023-08-07 7:19 ` Ijaz, Abdul B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87msyy3m3k.fsf@tromey.com \
--to=tom@tromey.com \
--cc=JiniSusan.George@amd.com \
--cc=abdul.b.ijaz@intel.com \
--cc=blarsen@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).