public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: "Ijaz, Abdul B via Gdb-patches" <gdb-patches@sourceware.org>
Cc: Tom Tromey <tom@tromey.com>,
	 "Ijaz, Abdul B" <abdul.b.ijaz@intel.com>,
	"JiniSusan.George@amd.com" <JiniSusan.George@amd.com>,
	 "eliz@gnu.org" <eliz@gnu.org>,
	 "blarsen@redhat.com" <blarsen@redhat.com>
Subject: Re: [PATCH v4 3/4] gdb/infrun: handle stepping through functions with DW_AT_trampoline
Date: Thu, 10 Aug 2023 10:56:29 -0600	[thread overview]
Message-ID: <87a5uy3kg2.fsf@tromey.com> (raw)
In-Reply-To: <SA1PR11MB68466C9467A82663E415983DCB0CA@SA1PR11MB6846.namprd11.prod.outlook.com> (Abdul B. via Gdb-patches Ijaz's message of "Mon, 7 Aug 2023 08:08:53 +0000")

>> It also seems a bit weird that skip_trampoline_functions only affects
>> this one subset of trampoline functions.

> So skip_trampoline_functions is so far only handling the skipping case
> for trampolines indicated by DW_AT_trampoline and not for any other
> case of these thunks emitted by compiler or by signal
> trampolines. Since this case is pretty much defined case for
> subroutines calling the target subroutine but not sure about others
> but may be these solib calls filtering may also be handled with the
> same. Please let me know if we want to filter other trampolines cases
> using the same filter. Mostly it should be "on" case but
> DW_AT_trampoline could be interesting for user if compiler emit it for
> virtual functions and user want to see all the trampoline calls so
> here there could be some cases for end user to see those trampoline
> calls but for thunks or rest I don’t know so let me know then I can
> asses of using the filter option for other trampolines.

Well, it just seems strange to me that after this series we would have
two different ways of handling trampolines, that depend on how the
trampoline is represented by the compiler (something nearly no user will
understand or care about), and that there will be two different ways to
elide frames from a "bt" (there's another one for frame filters).

If we think users don't want to see trampoline frames by default, by all
means elide them, but the setting ought to make sense from a user
perspective, not from a compiler implementer perspective.

Tom

  reply	other threads:[~2023-08-10 16:56 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-01 22:47 [PATCH v4 0/4] GDB support for DW_AT_trampoline Abdul Basit Ijaz
2023-08-01 22:47 ` [PATCH v4 1/4] gdb, dwarf: add support for DW_AT_trampoline in DWARF reader Abdul Basit Ijaz
2023-08-02 20:07   ` Tom Tromey
2023-08-07 14:43     ` Ijaz, Abdul B
2023-08-10 16:20       ` Tom Tromey
2023-08-02 20:13   ` Tom Tromey
2023-08-07 13:36     ` Ijaz, Abdul B
2023-08-10 16:18       ` Tom Tromey
2023-08-14 21:53         ` Ijaz, Abdul B
2023-08-01 22:47 ` [PATCH v4 2/4] gdb/symtab: add lookup for trampoline functions Abdul Basit Ijaz
2023-08-02 20:18   ` Tom Tromey
2023-08-07  7:40     ` Ijaz, Abdul B
2023-08-01 22:47 ` [PATCH v4 3/4] gdb/infrun: handle stepping through functions with DW_AT_trampoline Abdul Basit Ijaz
2023-08-02 11:52   ` Eli Zaretskii
2023-08-02 11:54     ` Ijaz, Abdul B
2023-08-02 20:33   ` Tom Tromey
2023-08-07  8:08     ` Ijaz, Abdul B
2023-08-10 16:56       ` Tom Tromey [this message]
2023-08-16 14:18         ` Ijaz, Abdul B
2023-08-01 22:47 ` [PATCH v4 4/4] gdb: Skip trampoline frames in the stack for printing or finish command Abdul Basit Ijaz
2023-08-02 11:52   ` Eli Zaretskii
2023-08-02 11:54     ` Ijaz, Abdul B
2023-08-02 20:41   ` Tom Tromey
2023-08-07 13:28     ` Ijaz, Abdul B
2023-08-10 17:45       ` Tom Tromey
2023-08-02 20:42   ` Tom Tromey
2023-08-07  7:19     ` Ijaz, Abdul B

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5uy3kg2.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=JiniSusan.George@amd.com \
    --cc=abdul.b.ijaz@intel.com \
    --cc=blarsen@redhat.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).