public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: Dragan Mladjenovic <Dragan.Mladjenovic@syrmia.com>
Cc: gdb-patches@sourceware.org,
	"Maciej W . Rozycki" <macro@orcam.me.uk>,
	Chao-ying Fu <cfu@wavecomp.com>,
	Faraz Shahbazker <fshahbazker@wavecomp.com>
Subject: Re: [PATCH v4 3/4] sim: Add partial support for IEEE 754-2008
Date: Tue, 1 Feb 2022 22:42:05 -0500	[thread overview]
Message-ID: <Yfn9jVmbFx4d8B05@vapier> (raw)
In-Reply-To: <20220201125302.30137-4-Dragan.Mladjenovic@syrmia.com>

[-- Attachment #1: Type: text/plain, Size: 562 bytes --]

On 01 Feb 2022 13:53, Dragan Mladjenovic wrote:
> +      /* In IEEE754-2008:
> +       * "minNum/maxNum is ... the canonicalized number if one
> +       * operand is a number and the other a quiet NaN." */

GNU style doesn't put * at the start of the wrapped line, and uses two
spaces before the closing */

> +/* Unordered/ordered comparison operators */

period at end

> +/* Changes the behaviour of the library to IEEE754-2008 or IEEE754-1985.
> + * The default for the library is IEEE754-1985. */

no leading * on wrapped lines and 2 spaces before */
-mike

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2022-02-02  3:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-01 12:52 [PATCH v4 0/4] sim: Add support for MIPS32/64 revision 6 Dragan Mladjenovic
2022-02-01 12:52 ` [PATCH v4 1/4] sim: Allow toggling of quiet NaN-bit semantics Dragan Mladjenovic
2022-02-02  3:39   ` Mike Frysinger
2022-02-01 12:53 ` [PATCH v4 2/4] sim: Factor out NaN handling in floating point operations Dragan Mladjenovic
2022-02-01 12:53 ` [PATCH v4 3/4] sim: Add partial support for IEEE 754-2008 Dragan Mladjenovic
2022-02-02  3:42   ` Mike Frysinger [this message]
2022-02-01 12:53 ` [PATCH v4 4/4] sim: mips: Add simulator support for mips32r6/mips64r6 Dragan Mladjenovic
2022-02-02  3:47   ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yfn9jVmbFx4d8B05@vapier \
    --to=vapier@gentoo.org \
    --cc=Dragan.Mladjenovic@syrmia.com \
    --cc=cfu@wavecomp.com \
    --cc=fshahbazker@wavecomp.com \
    --cc=gdb-patches@sourceware.org \
    --cc=macro@orcam.me.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).