From: Joel Brobecker <brobecker@adacore.com>
To: Maxim Kuvyrkov via Gdb-patches <gdb-patches@sourceware.org>
Cc: Luis Machado <Luis.Machado@arm.com>,
torbjorn.svensson@st.com, Yvan Roux <yvan.roux@linaro.org>,
Joel Brobecker <brobecker@adacore.com>
Subject: Re: [PATCH v3 0/5] arm: Add support for multiple stacks on Cortex-M
Date: Sun, 27 Feb 2022 15:35:41 +0400 [thread overview]
Message-ID: <YhtiDYH6L1lqzkYs@adacore.com> (raw)
In-Reply-To: <45235B67-731E-4EE7-81E1-62A720E963A4@linaro.org>
> Will you be able to review this patch series from Christophe?
I see that the v3 series was posted on Feb 4th, while on Feb 6th
I reviewed v2 :-(. This is really unfortunate that we don't have
a better system for tracking whether a version of a series is
trully the latest version.
Can you take a look at the comments and question I asked in v2,
and publish a v4 which takes those into account? Please Cc: me
on the submission of the patches, this will help me remember
to prioritize those patches.
>
> Thank you,
>
> --
> Maxim Kuvyrkov
> https://www.linaro.org
>
> > On 4 Feb 2022, at 11:41, Christophe Lyon via Gdb-patches <gdb-patches@sourceware.org> wrote:
> >
> > From: Christophe Lyon <christophe.lyon@foss.st.com>
> >
> > This patch series introduces support for the multiple stack pointers
> > on v8-M architecture (MSP_S, MSP_NS, PSP_S, PSP_NS).
> >
> > This enables to unwind through Secure vs Non-secure context switches.
> >
> > Along the way, the first patch adds support to detect vpush
> > instructions in function prologues, which in particular is used in the
> > CMSE trampolines.
> >
> > v3 fixes two small silly mistakes in patches 4 and 5.
> >
> > Christophe Lyon (5):
> > gdb/arm: Fix prologue analysis to support vpush
> > gdb/arm: Define MSP and PSP registers for M-Profile
> > gdb/arm: Introduce arm_cache_init
> > gdb/arm: Add support for multiple stack pointers on Cortex-M
> > gdb/arm: Extend arm_m_addr_is_magic to support FNC_RETURN, add
> > unwind-ns-to-s command
> >
> > gdb/NEWS | 5 +
> > gdb/arch/arm.c | 6 +
> > gdb/arch/arm.h | 1 +
> > gdb/arm-tdep.c | 698 +++++++++++++++++++++++++-----
> > gdb/arm-tdep.h | 10 +
> > gdb/doc/gdb.texinfo | 10 +
> > gdb/features/Makefile | 1 +
> > gdb/features/arm/arm-m-system.c | 15 +
> > gdb/features/arm/arm-m-system.xml | 12 +
> > gdb/features/arm/arm-secext.c | 17 +
> > gdb/features/arm/arm-secext.xml | 15 +
> > 11 files changed, 691 insertions(+), 99 deletions(-)
> > create mode 100644 gdb/features/arm/arm-m-system.c
> > create mode 100644 gdb/features/arm/arm-m-system.xml
> > create mode 100644 gdb/features/arm/arm-secext.c
> > create mode 100644 gdb/features/arm/arm-secext.xml
> >
> > --
> > 2.25.1
> >
>
--
Joel
next prev parent reply other threads:[~2022-02-27 11:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 8:41 christophe.lyon.oss
2022-02-04 8:41 ` [PATCH v3 1/5] gdb/arm: Fix prologue analysis to support vpush christophe.lyon.oss
2022-02-04 8:41 ` [PATCH v3 2/5] gdb/arm: Define MSP and PSP registers for M-Profile christophe.lyon.oss
2022-02-04 8:41 ` [PATCH v3 3/5] gdb/arm: Introduce arm_cache_init christophe.lyon.oss
2022-02-04 8:41 ` [PATCH v3 4/5] gdb/arm: Add support for multiple stack pointers on Cortex-M christophe.lyon.oss
2022-02-04 8:41 ` [PATCH v3 5/5] gdb/arm: Extend arm_m_addr_is_magic to support FNC_RETURN, add unwind-ns-to-s command christophe.lyon.oss
2022-02-25 9:54 ` [PATCH v3 0/5] arm: Add support for multiple stacks on Cortex-M Maxim Kuvyrkov
2022-02-27 11:35 ` Joel Brobecker [this message]
2022-02-28 10:38 ` Christophe Lyon
2022-03-06 10:48 ` Joel Brobecker
2022-03-06 21:19 ` Christophe Lyon
2022-03-11 9:40 ` Yvan Roux
2022-03-11 9:47 ` Christophe Lyon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhtiDYH6L1lqzkYs@adacore.com \
--to=brobecker@adacore.com \
--cc=Luis.Machado@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=torbjorn.svensson@st.com \
--cc=yvan.roux@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).