From: Luis Machado <luis.machado@arm.com>
To: Yvan Roux <yvan.roux@foss.st.com>, gdb-patches@sourceware.org
Cc: Torbjorn SVENSSON <torbjorn.svensson@st.com>
Subject: Re: [PATCH] gdb/arm: Add support for FPU registers in prologue unwinder
Date: Wed, 1 Jun 2022 10:59:43 +0100 [thread overview]
Message-ID: <a0736e3a-756a-1175-1235-be36c051ad81@arm.com> (raw)
In-Reply-To: <20220531133336.GC13232@gnbcxd0114.gnb.st.com>
On 5/31/22 14:33, Yvan Roux wrote:
> Hi,
>
> The prologue unwinder had support for FPU registers, but only to
> calculate the correct offset on the stack, the values were not saved.
>
> Signed-off-by: Torbj�rn SVENSSON <torbjorn.svensson@st.com>
> Signed-off-by: Yvan Roux <yvan.roux@foss.st.com>
> ---
> gdb/arm-tdep.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c
> index 49664093f00..0f204ac6a9f 100644
> --- a/gdb/arm-tdep.c
> +++ b/gdb/arm-tdep.c
> @@ -1437,7 +1437,7 @@ thumb_analyze_prologue (struct gdbarch *gdbarch,
> cache->framesize = -regs[ARM_SP_REGNUM].k;
> }
>
> - for (i = 0; i < 16; i++)
> + for (i = 0; i < gdbarch_num_regs (gdbarch); i++)
> if (stack.find_reg (gdbarch, i, &offset))
> cache->saved_regs[i].set_addr (offset);
>
Thanks, this is OK.
prev parent reply other threads:[~2022-06-01 10:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 13:33 Yvan Roux
2022-06-01 9:59 ` Luis Machado [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0736e3a-756a-1175-1235-be36c051ad81@arm.com \
--to=luis.machado@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=torbjorn.svensson@st.com \
--cc=yvan.roux@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).