public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] gdb/arm: Add support for FPU registers in prologue unwinder
@ 2022-05-31 13:33 Yvan Roux
  2022-06-01  9:59 ` Luis Machado
  0 siblings, 1 reply; 2+ messages in thread
From: Yvan Roux @ 2022-05-31 13:33 UTC (permalink / raw)
  To: gdb-patches, Luis Machado; +Cc: Torbjorn SVENSSON

Hi,

The prologue unwinder had support for FPU registers, but only to
calculate the correct offset on the stack, the values were not saved.

Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@st.com>
Signed-off-by: Yvan Roux <yvan.roux@foss.st.com>
---
 gdb/arm-tdep.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c
index 49664093f00..0f204ac6a9f 100644
--- a/gdb/arm-tdep.c
+++ b/gdb/arm-tdep.c
@@ -1437,7 +1437,7 @@ thumb_analyze_prologue (struct gdbarch *gdbarch,
       cache->framesize = -regs[ARM_SP_REGNUM].k;
     }
 
-  for (i = 0; i < 16; i++)
+  for (i = 0; i < gdbarch_num_regs (gdbarch); i++)
     if (stack.find_reg (gdbarch, i, &offset))
       cache->saved_regs[i].set_addr (offset);
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] gdb/arm: Add support for FPU registers in prologue unwinder
  2022-05-31 13:33 [PATCH] gdb/arm: Add support for FPU registers in prologue unwinder Yvan Roux
@ 2022-06-01  9:59 ` Luis Machado
  0 siblings, 0 replies; 2+ messages in thread
From: Luis Machado @ 2022-06-01  9:59 UTC (permalink / raw)
  To: Yvan Roux, gdb-patches; +Cc: Torbjorn SVENSSON

On 5/31/22 14:33, Yvan Roux wrote:
> Hi,
> 
> The prologue unwinder had support for FPU registers, but only to
> calculate the correct offset on the stack, the values were not saved.
> 
> Signed-off-by: Torbj�rn SVENSSON <torbjorn.svensson@st.com>
> Signed-off-by: Yvan Roux <yvan.roux@foss.st.com>
> ---
>   gdb/arm-tdep.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c
> index 49664093f00..0f204ac6a9f 100644
> --- a/gdb/arm-tdep.c
> +++ b/gdb/arm-tdep.c
> @@ -1437,7 +1437,7 @@ thumb_analyze_prologue (struct gdbarch *gdbarch,
>         cache->framesize = -regs[ARM_SP_REGNUM].k;
>       }
>   
> -  for (i = 0; i < 16; i++)
> +  for (i = 0; i < gdbarch_num_regs (gdbarch); i++)
>       if (stack.find_reg (gdbarch, i, &offset))
>         cache->saved_regs[i].set_addr (offset);
>   

Thanks, this is OK.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-06-01 10:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-31 13:33 [PATCH] gdb/arm: Add support for FPU registers in prologue unwinder Yvan Roux
2022-06-01  9:59 ` Luis Machado

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).