From: John Baldwin <jhb@FreeBSD.org>
To: Tom de Vries <tdevries@suse.de>, Simon Marchi <simark@simark.ca>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/testsuite] Add -q to INTERNAL_GDBFLAGS
Date: Mon, 10 Apr 2023 12:40:22 -0700 [thread overview]
Message-ID: <a101636f-9694-c7f1-7b6d-7832c2373b2c@FreeBSD.org> (raw)
In-Reply-To: <6e123fa8-5619-361a-adae-ff115bdfa0e3@suse.de>
On 4/7/23 1:25 AM, Tom de Vries via Gdb-patches wrote:
> On 4/7/23 09:25, Tom de Vries via Gdb-patches wrote:
>>> Not having the license text makes it a little less obvious in the log
>>> when gdb has been restarted, so that might be a bit more confusing.
>>
>> Ack, true.
>
> And if you want something more verbose, we could always do some variant of:
> ...
> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
> index 7538071d1cf..4743150a878 100644
> --- a/gdb/testsuite/lib/gdb.exp
> +++ b/gdb/testsuite/lib/gdb.exp
> @@ -2305,7 +2305,7 @@ proc default_gdb_start { } {
> }
> -re "^$gdb_prompt $" {
> # Output with -q.
> - verbose "GDB initialized."
> + verbose -log "GDB initialized."
> }
> -re "^\033\\\[.2004h$gdb_prompt $" {
> # Output with -q, and bracketed paste mode enabled, see above.
> ...
> to get:
> ...
> PASS: gdb.threads/attach-many-short-lived-threads.exp: successfully
> compiled posix threads test case
> builtin_spawn
> /data/vries/gdb/leap-15-4/build/gdb/testsuite/../../gdb/gdb -nw -nx -q
> -iex set height 0 -iex set width 0 -data-directory
> /data/vries/gdb/leap-15-4/build/gdb/data-directory^M
> (gdb) GDB initialized.
> set height 0^M
> (gdb) set width 0^M
I would prefer this type of approach for the "start of a session" sentinel.
--
John Baldwin
next prev parent reply other threads:[~2023-04-10 19:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 18:34 Tom de Vries
2023-04-06 0:17 ` Simon Marchi
2023-04-07 7:25 ` Tom de Vries
2023-04-07 8:25 ` Tom de Vries
2023-04-10 19:40 ` John Baldwin [this message]
2023-04-19 14:04 ` [PATCH] [gdb/testsuite] Use verbose -log for "GDB initialized" Tom de Vries
2023-05-02 15:46 ` [PING] " Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a101636f-9694-c7f1-7b6d-7832c2373b2c@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).