public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/testsuite] Add -q to INTERNAL_GDBFLAGS
Date: Wed, 5 Apr 2023 20:17:07 -0400	[thread overview]
Message-ID: <8ca29409-2a43-c4a1-ebbe-02ae519b79e4@simark.ca> (raw)
In-Reply-To: <20230405183410.13468-1-tdevries@suse.de>

On 4/5/23 14:34, Tom de Vries via Gdb-patches wrote:
> Whenever we start gdb in the testsuite, we have the rather verbose:
> ...
> $ gdb
> GNU gdb (GDB) 14.0.50.20230405-git
> Copyright (C) 2023 Free Software Foundation, Inc.
> License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law.
> Type "show copying" and "show warranty" for details.
> This GDB was configured as "x86_64-pc-linux-gnu".
> Type "show configuration" for configuration details.
> For bug reporting instructions, please see:
> <https://www.gnu.org/software/gdb/bugs/>.
> Find the GDB manual and other documentation resources online at:
>     <http://www.gnu.org/software/gdb/documentation/>.
> 
> For help, type "help".
> Type "apropos word" to search for commands related to "word".
> (gdb)
> ...
> 
> This makes gdb.log longer than necessary and harder to read.
> 
> We do need to test that the output is produced, but that should be limited to
> one or a few test-cases.
> 
> Fix this by adding -q to INTERNAL_GDBFLAGS, such that we simply have:
> ...
> $ gdb -q
> (gdb)

The license text never really bothered me in gdb.log, when I consult
gdb.log I usually search for some string, so it just skips over that.
Not having the license text makes it a little less obvious in the log
when gdb has been restarted, so that might be a bit more confusing.  But
otherwise, I don't really mind your change, I'll get used to it.

Simon

  reply	other threads:[~2023-04-06  0:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-05 18:34 Tom de Vries
2023-04-06  0:17 ` Simon Marchi [this message]
2023-04-07  7:25   ` Tom de Vries
2023-04-07  8:25     ` Tom de Vries
2023-04-10 19:40       ` John Baldwin
2023-04-19 14:04         ` [PATCH] [gdb/testsuite] Use verbose -log for "GDB initialized" Tom de Vries
2023-05-02 15:46           ` [PING] " Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ca29409-2a43-c4a1-ebbe-02ae519b79e4@simark.ca \
    --to=simark@simark.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).