Re: [PATCH] [gdb/testsuite] Add -q to INTERNAL_GDBFLAGS

[Tom de Vries <tdevries@suse.de>]

On 4/6/23 02:17, Simon Marchi wrote:
> On 4/5/23 14:34, Tom de Vries via Gdb-patches wrote:
>> Whenever we start gdb in the testsuite, we have the rather verbose:
>> ...
>> $ gdb
>> GNU gdb (GDB) 14.0.50.20230405-git
>> Copyright (C) 2023 Free Software Foundation, Inc.
>> License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
>> This is free software: you are free to change and redistribute it.
>> There is NO WARRANTY, to the extent permitted by law.
>> Type "show copying" and "show warranty" for details.
>> This GDB was configured as "x86_64-pc-linux-gnu".
>> Type "show configuration" for configuration details.
>> For bug reporting instructions, please see:
>> <https://www.gnu.org/software/gdb/bugs/>.
>> Find the GDB manual and other documentation resources online at:
>>      <http://www.gnu.org/software/gdb/documentation/>.
>>
>> For help, type "help".
>> Type "apropos word" to search for commands related to "word".
>> (gdb)
>> ...
>>
>> This makes gdb.log longer than necessary and harder to read.
>>
>> We do need to test that the output is produced, but that should be limited to
>> one or a few test-cases.
>>
>> Fix this by adding -q to INTERNAL_GDBFLAGS, such that we simply have:
>> ...
>> $ gdb -q
>> (gdb)
> 
> The license text never really bothered me in gdb.log, when I consult
> gdb.log I usually search for some string, so it just skips over that.

I see.

FWIW, I've always found it a tiny bit annoying, but got triggered to do 
something about it when playing around with test-case 
gdb.tui/tui-layout-asm.exp where I tried to reduce tui_asm_window_width 
to simulate the problem fixed by commit abdd4204a2f ("Fix for 
gdb.tui/tui-layout-asm.exp") on x86_64, and ran into the paging prompt 
due to the license text.

I'm also working on a patch to use -eiex "set height 0" in 
INTERNAL_GDBFLAGS to make sure that the paging problem still doesn't 
happen when we filter out -q from INTERNAL_GDBFLAGS (and while working 
on that patch I ran into PR30320).

> Not having the license text makes it a little less obvious in the log
> when gdb has been restarted, so that might be a bit more confusing.

Ack, true.

For me, the license text takes about half of my screen estate, so I 
scroll past it often, and it reduces the amount of actual information on 
my screen.

So I guess this is about the balance between small things are hard to 
spot and large things are hard to ignore.

> But
> otherwise, I don't really mind your change, I'll get used to it.
> 

OK, thanks for the review, I'll commit shortly.

Thanks,
- Tom