public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: "Дилян Палаузов" <dilyan.palauzov@aegee.org>
To: gdb-patches@sourceware.org
Subject: Don't build readline/libreadline.a, when --with-system-readline is supplied
Date: Wed, 12 Dec 2018 07:46:00 -0000	[thread overview]
Message-ID: <a2195fc03d1cc1629afa7ac28922f239ac3d705f.camel@aegee.org> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=18632

The bundled libreadline is always built, even if the system is
./configure'd --with-system-readline and the build libreadline.a is not
used.

Proposed patch:

Fix ./configure.ac not to proceed readline/, when --with-system-
readline is provided

diff --git a/configure.ac b/configure.ac
index 159f968..adf6dfb 100644
--- a/configure.ac
+++ b/configure.ac
@@ -253,6 +253,12 @@ if test x$with_system_zlib = xyes ; then
   noconfigdirs="$noconfigdirs zlib"
 fi
 
+# Don't compile the bundled readline/libreadline.a if --with-system-
readline
+# is provided.
+if test x$with_system_readline = xyes ; then
+  noconfigdirs="$noconfigdirs readline"
+fi
+
 # some tools are so dependent upon X11 that if we're not building with
X, 
 # it's not even worth trying to configure, much less build, that tool.

             reply	other threads:[~2018-12-12  7:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-12  7:46 Дилян Палаузов [this message]
2018-12-31 12:18 ` +reminder+ " Дилян Палаузов
2019-01-03  5:09 ` Simon Marchi
2022-10-20  9:22   ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a2195fc03d1cc1629afa7ac28922f239ac3d705f.camel@aegee.org \
    --to=dilyan.palauzov@aegee.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).