From: Simon Marchi <simon.marchi@polymtl.ca>
To: "Дилян Палаузов" <dilyan.palauzov@aegee.org>
Cc: gdb-patches@sourceware.org
Subject: Re: Don't build readline/libreadline.a, when --with-system-readline is supplied
Date: Thu, 03 Jan 2019 05:09:00 -0000 [thread overview]
Message-ID: <8cb2cddc50577d82422176d1ffebe140@polymtl.ca> (raw)
In-Reply-To: <a2195fc03d1cc1629afa7ac28922f239ac3d705f.camel@aegee.org>
On 2018-12-12 02:46, ÐилÑн ÐалаÑзов wrote:
> https://sourceware.org/bugzilla/show_bug.cgi?id=18632
>
> The bundled libreadline is always built, even if the system is
> ./configure'd --with-system-readline and the build libreadline.a is not
> used.
>
> Proposed patch:
>
> Fix ./configure.ac not to proceed readline/, when --with-system-
> readline is provided
>
> diff --git a/configure.ac b/configure.ac
> index 159f968..adf6dfb 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -253,6 +253,12 @@ if test x$with_system_zlib = xyes ; then
> noconfigdirs="$noconfigdirs zlib"
> fi
>
> +# Don't compile the bundled readline/libreadline.a if --with-system-
> readline
> +# is provided.
> +if test x$with_system_readline = xyes ; then
> + noconfigdirs="$noconfigdirs readline"
> +fi
> +
> # some tools are so dependent upon X11 that if we're not building with
> X,
> # it's not even worth trying to configure, much less build, that tool.
Thanks. I've tested it and pushed it (with the generated configure and
the matching ChangeLog entry).
For those who wonder, Joseph Myers suggested we take care of this patch
in GDB and then sync it with gcc [1].
Simon
[1] https://gcc.gnu.org/ml/gcc-patches/2018-12/msg00299.html
next prev parent reply other threads:[~2019-01-03 5:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 7:46 Дилян Палаузов
2018-12-31 12:18 ` +reminder+ " Дилян Палаузов
2019-01-03 5:09 ` Simon Marchi [this message]
2022-10-20 9:22 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cb2cddc50577d82422176d1ffebe140@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=dilyan.palauzov@aegee.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).