Re: Don't build readline/libreadline.a, when --with-system-readline is supplied

[Tom de Vries <tdevries@suse.de>]

On 1/3/19 06:09, Simon Marchi wrote:
> On 2018-12-12 02:46, Дилян Палаузов wrote:
>> https://sourceware.org/bugzilla/show_bug.cgi?id=18632
>>
>> The bundled libreadline is always built, even if the system is
>> ./configure'd --with-system-readline and the build libreadline.a is not
>> used.
>>
>> Proposed patch:
>>
>> Fix ./configure.ac not to proceed readline/, when --with-system-
>> readline is provided
>>
>> diff --git a/configure.ac b/configure.ac
>> index 159f968..adf6dfb 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -253,6 +253,12 @@ if test x$with_system_zlib = xyes ; then
>>    noconfigdirs="$noconfigdirs zlib"
>>  fi
>>
>> +# Don't compile the bundled readline/libreadline.a if --with-system-
>> readline
>> +# is provided.
>> +if test x$with_system_readline = xyes ; then
>> +  noconfigdirs="$noconfigdirs readline"
>> +fi
>> +
>>  # some tools are so dependent upon X11 that if we're not building with
>> X,
>>  # it's not even worth trying to configure, much less build, that tool.
> 
> Thanks.  I've tested it and pushed it (with the generated configure and 
> the matching ChangeLog entry).
> 
> For those who wonder, Joseph Myers suggested we take care of this patch 
> in GDB and then sync it with gcc [1].
> 

Which never happened, and therefore a recent sync from gcc repo dropped 
this patch, so I reopened 
https://sourceware.org/bugzilla/show_bug.cgi?id=18632.

Thanks,
- Tom

> Simon
> 
> [1] https://gcc.gnu.org/ml/gcc-patches/2018-12/msg00299.html