[[RFC][PATCH][PR gdb/24069]] gdb/testsuite/README: update default value of INTERNAL_GDBFLAGS

[[RFC][PATCH][PR gdb/24069]] gdb/testsuite/README: update default value of INTERNAL_GDBFLAGS

[Philippe Blain]

The INTERNAL_GDBFLAGS runtest variable was updated in 55c3ad88013
([gdb/testsuite] Prevent pagination in GDB_INTERNALFLAGS, 2020-10-26) to
disable pagination, and in aae1c79a03a (PR python/12227..., 2010-12-07)
to point to the data directory, but its default value mentioned in the
testsuite's README was not kept up to date.

Update the README accordingly, and mention where the default value is
set, so that it's easier for futur new contributors to check if the
default mentioned in the README is still current.
---

Notes:
    I noticed that while testing the fix for PR 24069, since I wanted
    to use my '~/.gdbinit' with 'set startup-with-shell off' for all tests,
    and found out that setting INTERNAL_GDBFLAGS to only '-nw' made some things
    a little worse (as GDB was then missing '-data-directory').

 gdb/testsuite/README | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/gdb/testsuite/README b/gdb/testsuite/README
index 7552774c78b..1ba50c43f73 100644
--- a/gdb/testsuite/README
+++ b/gdb/testsuite/README
@@ -168,11 +168,14 @@ INTERNAL_GDBFLAGS
 
 Command line options passed to all GDB invocations.
 
-The default is "-nw -nx".
+The default is set in lib/gdb.exp and is currently
+"-nw -nx -data-directory /path/to/build/directory/gdb/data-directory -iex 'set height 0' -iex 'set width 0'".
 
 `-nw' disables any of the windowed interfaces.
 `-nx' disables ~/.gdbinit, so that it doesn't interfere with
 the tests.
+`-data-directory` points the the data directory in the build directory
+`-iex 'set {height,width} 0'` disable pagination
 
 This is actually considered an internal variable, and you
 won't normally want to change it.  However, in some situations,
@@ -193,7 +196,10 @@ a .gdbinit.  For example:
 	HOME=`pwd` runtest \
 	  GDB=/usr/bin/gdb \
 	  GDBSERVER=/usr/bin/gdbserver \
-	  INTERNAL_GDBFLAGS=-nw
+	  INTERNAL_GDBFLAGS="-nw -iex 'set height 0' -iex 'set width 0'"
+
+Note that we do not need to specify '-data-directory' here
+as we are testing an installed GDB.
 
 GDB_PARALLEL
 

base-commit: 0acf434a23768449cbb4b3732355f3f2febecaee
prerequisite-patch-id: aa40f05c60f391581f8aff17335000a5240d00cb
prerequisite-patch-id: cfae52dea4b1af9a4c14ac4dbdcae3cda9c946db
-- 
2.29.2

Re: [[RFC][PATCH][PR gdb/24069]] gdb/testsuite/README: update default value of INTERNAL_GDBFLAGS

[Philippe Blain]

Hello, 

Le 2022-02-19 à 16:24, Philippe Blain via Gdb-patches a écrit :
> The INTERNAL_GDBFLAGS runtest variable was updated in 55c3ad88013

I'm sorry to have disturbed you all with these erronous CCs. I'm a little new
to the whole git send-email dance and went a little fast. 

You can disregard this patch, I'll send a new mail with the right CCs and
a better title.

Philippe.