From: "Maciej W. Rozycki" <macro@embecosm.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <aburgess@redhat.com>,
Simon Marchi <simon.marchi@polymtl.ca>,
Tom Tromey <tom@tromey.com>, Simon Sobisch <simonsobisch@web.de>
Subject: [PATCH v4 4/8] GDB/testsuite: Tighten `set print elements' error check
Date: Wed, 9 Mar 2022 19:18:16 +0000 (GMT) [thread overview]
Message-ID: <alpine.DEB.2.20.2203091349560.11552@tpp.orcam.me.uk> (raw)
In-Reply-To: <alpine.DEB.2.20.2203031442040.11552@tpp.orcam.me.uk>
Match the whole error message expected to be given rather than omitting
the part about the "unlimited" keyword. There's no point in omitting
the missing part first, and second with an upcoming change the part in
parentheses will no longer be a fixed string, so doing a full match will
ensure the algorithm correctly builds the message expected here. Also
avoid any wildcard matches.
---
New change in v4.
---
gdb/testsuite/gdb.base/default.exp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
gdb-test-set-print-elements-tightening.diff
Index: src/gdb/testsuite/gdb.base/default.exp
===================================================================
--- src.orig/gdb/testsuite/gdb.base/default.exp
+++ src/gdb/testsuite/gdb.base/default.exp
@@ -525,7 +525,8 @@ gdb_test_no_output "set print asm-demang
#test set print demangle
gdb_test_no_output "set print demangle" "set print demangle"
#test set print elements
-gdb_test "set print elements" "Argument required .integer to set it to.*"
+gdb_test "set print elements" \
+ "Argument required \\(integer to set it to, or \"unlimited\"\\)\\."
#test set print object
gdb_test_no_output "set print object" "set print object"
#test set print pretty
next prev parent reply other threads:[~2022-03-09 19:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 19:17 [PATCH v4 0/8] gdb: split array and string limiting options Maciej W. Rozycki
2022-03-09 19:17 ` [PATCH v4 1/8] GDB: Remove extraneous full stops from `set' command error messages Maciej W. Rozycki
2022-03-09 19:18 ` [PATCH v4 2/8] GDB/Python: Use None for `var_zuinteger_unlimited' value set to `unlimited' Maciej W. Rozycki
2022-03-09 19:18 ` [PATCH v4 3/8] GDB: Add `NUMBER' completion to `set' integer commands Maciej W. Rozycki
2022-03-09 19:18 ` Maciej W. Rozycki [this message]
2022-03-09 19:18 ` [PATCH v4 5/8] GDB/testsuite: Add coverage for `print -elements' command Maciej W. Rozycki
2022-03-09 19:18 ` [PATCH v4 6/8] GDB: Allow arbitrary keywords in integer set commands Maciej W. Rozycki
2022-03-09 19:18 ` [PATCH v4 7/8] GDB: Add a character string limiting option Maciej W. Rozycki
2022-03-09 19:51 ` Eli Zaretskii
2022-03-09 20:40 ` Maciej W. Rozycki
2022-03-10 0:03 ` Maciej W. Rozycki
2022-03-10 6:35 ` Eli Zaretskii
2022-03-10 6:28 ` Eli Zaretskii
2022-03-10 10:08 ` Maciej W. Rozycki
2022-03-10 11:55 ` Eli Zaretskii
2022-03-10 12:25 ` Maciej W. Rozycki
2022-03-10 17:15 ` Tom Tromey
2022-03-30 10:38 ` Maciej W. Rozycki
2022-03-30 13:15 ` Pedro Alves
2022-03-30 14:17 ` Maciej W. Rozycki
2022-03-09 19:18 ` [PATCH v4 8/8] GDB/testsuite: Expand for character string limiting options Maciej W. Rozycki
2022-03-09 19:47 ` [PATCH v4 0/8] gdb: split array and " Simon Sobisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.2203091349560.11552@tpp.orcam.me.uk \
--to=macro@embecosm.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=simonsobisch@web.de \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).