From: Eli Zaretskii <eliz@gnu.org>
To: "Maciej W. Rozycki" <macro@embecosm.com>
Cc: gdb-patches@sourceware.org, simonsobisch@web.de, tom@tromey.com,
aburgess@redhat.com
Subject: Re: [PATCH v4 7/8] GDB: Add a character string limiting option
Date: Thu, 10 Mar 2022 08:28:09 +0200 [thread overview]
Message-ID: <83mthye2yu.fsf@gnu.org> (raw)
In-Reply-To: <alpine.DEB.2.20.2203092025330.11552@tpp.orcam.me.uk> (macro@embecosm.com)
> Date: Wed, 9 Mar 2022 20:40:20 +0000 (GMT)
> From: "Maciej W. Rozycki" <macro@embecosm.com>
> cc: gdb-patches@sourceware.org, simonsobisch@web.de,
> Tom Tromey <tom@tromey.com>, Andrew Burgess <aburgess@redhat.com>
>
> > And, btw, we actually count bytes, not characters, right? If the
> > string contains multibyte sequences, we don't count characters. I
> > think this should be mentioned.
>
> We do count characters not bytes, as previously discussed; cf.:
> <https://sourceware.org/pipermail/gdb-patches/2021-December/184466.html>.
> Multibyte sequences comprising a single character are treated as such.
> This change does not affect it.
OK, but I still think this should be mentioned in the manual.
Previously, the setting was for "array elements", and was not specific
to character strings (though I would think that "array elements" in
case of a 'char' strings are bytes, not multibyte character
sequences), but now we are specifically addressing character strings,
so this issue begs a question that IMO the manual should answer.
Thanks.
next prev parent reply other threads:[~2022-03-10 6:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 19:17 [PATCH v4 0/8] gdb: split array and string limiting options Maciej W. Rozycki
2022-03-09 19:17 ` [PATCH v4 1/8] GDB: Remove extraneous full stops from `set' command error messages Maciej W. Rozycki
2022-03-09 19:18 ` [PATCH v4 2/8] GDB/Python: Use None for `var_zuinteger_unlimited' value set to `unlimited' Maciej W. Rozycki
2022-03-09 19:18 ` [PATCH v4 3/8] GDB: Add `NUMBER' completion to `set' integer commands Maciej W. Rozycki
2022-03-09 19:18 ` [PATCH v4 4/8] GDB/testsuite: Tighten `set print elements' error check Maciej W. Rozycki
2022-03-09 19:18 ` [PATCH v4 5/8] GDB/testsuite: Add coverage for `print -elements' command Maciej W. Rozycki
2022-03-09 19:18 ` [PATCH v4 6/8] GDB: Allow arbitrary keywords in integer set commands Maciej W. Rozycki
2022-03-09 19:18 ` [PATCH v4 7/8] GDB: Add a character string limiting option Maciej W. Rozycki
2022-03-09 19:51 ` Eli Zaretskii
2022-03-09 20:40 ` Maciej W. Rozycki
2022-03-10 0:03 ` Maciej W. Rozycki
2022-03-10 6:35 ` Eli Zaretskii
2022-03-10 6:28 ` Eli Zaretskii [this message]
2022-03-10 10:08 ` Maciej W. Rozycki
2022-03-10 11:55 ` Eli Zaretskii
2022-03-10 12:25 ` Maciej W. Rozycki
2022-03-10 17:15 ` Tom Tromey
2022-03-30 10:38 ` Maciej W. Rozycki
2022-03-30 13:15 ` Pedro Alves
2022-03-30 14:17 ` Maciej W. Rozycki
2022-03-09 19:18 ` [PATCH v4 8/8] GDB/testsuite: Expand for character string limiting options Maciej W. Rozycki
2022-03-09 19:47 ` [PATCH v4 0/8] gdb: split array and " Simon Sobisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mthye2yu.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=macro@embecosm.com \
--cc=simonsobisch@web.de \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).