From: Simon Sobisch <simonsobisch@web.de>
To: "Maciej W. Rozycki" <macro@embecosm.com>, gdb-patches@sourceware.org
Cc: Andrew Burgess <aburgess@redhat.com>,
Simon Marchi <simon.marchi@polymtl.ca>,
Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH v4 0/8] gdb: split array and string limiting options
Date: Wed, 9 Mar 2022 20:47:30 +0100 [thread overview]
Message-ID: <c29d2d2b-0376-6985-234e-541f7fe93e44@web.de> (raw)
In-Reply-To: <alpine.DEB.2.20.2203031442040.11552@tpp.orcam.me.uk>
Thank you for your work on this.
I like all patches but can't really comment on "6 of 8" (with the reason
that I don't understand it fully, the "theory" does sound good).
I'm really looking forward to see this (in GDB12 I assume).
Simon
Am 09.03.2022 um 20:17 schrieb Maciej W. Rozycki:
> Hi,
>
> I have retained the original subject for the cover letter for threading
> purposes, however this has now otherwise become a small patch series and
> Andrew's original change has a different heading now.
>
> This is v4 for Andrew's original proposal to split the `set/show print
> elements' options into two, so that there are separate `set/show print
> characters' options to control how many characters of a string are
> printed. Following earlier discussion for compatibility with existing
> setups I have implemented a mechanism to make the `set print characters'
> setting follow that of `set print elements' by default. Consequently what
> was a single change has now grown into a patch series.
>
> In this series I fix some preexisting issues in the area first, implement
> the general framework for extra literals used with integer settings second
> and then add the original change for `set print characters' from Andrew,
> adjusted accordingly, followed by a testsuite update as a separate change.
> This is so as to ensure the semantics of the existing `set print elements'
> knob hasn't changed in the default `set print characters' state (a small
> update for the test suite is nevertheless included with the `set print
> characters' command proper, because inevitably the relevant commands that
> list commands now print additional entries, plus there's been a minimal
> test case update included for the verification of setting defaults).
>
> I think there's little more to say here except that changes in the series
> have been individually regression-tested with a native `x86_64-linux-gnu'
> configuration, and that I have visually examined the result of changes to
> the GDB manual in the info and PDF formats.
>
> See individual change descriptions for details.
>
> OK to apply?
>
> Maciej
prev parent reply other threads:[~2022-03-09 19:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 19:17 Maciej W. Rozycki
2022-03-09 19:17 ` [PATCH v4 1/8] GDB: Remove extraneous full stops from `set' command error messages Maciej W. Rozycki
2022-03-09 19:18 ` [PATCH v4 2/8] GDB/Python: Use None for `var_zuinteger_unlimited' value set to `unlimited' Maciej W. Rozycki
2022-03-09 19:18 ` [PATCH v4 3/8] GDB: Add `NUMBER' completion to `set' integer commands Maciej W. Rozycki
2022-03-09 19:18 ` [PATCH v4 4/8] GDB/testsuite: Tighten `set print elements' error check Maciej W. Rozycki
2022-03-09 19:18 ` [PATCH v4 5/8] GDB/testsuite: Add coverage for `print -elements' command Maciej W. Rozycki
2022-03-09 19:18 ` [PATCH v4 6/8] GDB: Allow arbitrary keywords in integer set commands Maciej W. Rozycki
2022-03-09 19:18 ` [PATCH v4 7/8] GDB: Add a character string limiting option Maciej W. Rozycki
2022-03-09 19:51 ` Eli Zaretskii
2022-03-09 20:40 ` Maciej W. Rozycki
2022-03-10 0:03 ` Maciej W. Rozycki
2022-03-10 6:35 ` Eli Zaretskii
2022-03-10 6:28 ` Eli Zaretskii
2022-03-10 10:08 ` Maciej W. Rozycki
2022-03-10 11:55 ` Eli Zaretskii
2022-03-10 12:25 ` Maciej W. Rozycki
2022-03-10 17:15 ` Tom Tromey
2022-03-30 10:38 ` Maciej W. Rozycki
2022-03-30 13:15 ` Pedro Alves
2022-03-30 14:17 ` Maciej W. Rozycki
2022-03-09 19:18 ` [PATCH v4 8/8] GDB/testsuite: Expand for character string limiting options Maciej W. Rozycki
2022-03-09 19:47 ` Simon Sobisch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c29d2d2b-0376-6985-234e-541f7fe93e44@web.de \
--to=simonsobisch@web.de \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=macro@embecosm.com \
--cc=simon.marchi@polymtl.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).