From: Lancelot SIX <Lancelot.Six@amd.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org, lsix@lancelotsix.com
Subject: Re: [PATCH v6 3/3] gdb/gcore: interrupt all threads to generate core in non-stop targets
Date: Wed, 22 Mar 2023 16:59:42 +0000 [thread overview]
Message-ID: <b0808477-ecd8-9391-9880-b97356928d79@amd.com> (raw)
In-Reply-To: <83o7ok68hm.fsf@gnu.org>
Hi Eli,
>>
>> +If the current inferior's target is non-stop, @value{GDBN} ensures that
>
> Please add a cross-reference after "non-stop" to where we describe
> that mode.
I have done the change locally. This part of the patch is now:
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 6c811b8be2e..00949b4b950 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -13763,6 +13763,12 @@ Produce a core dump of the inferior process.
The optional argument
specified, the file name defaults to @file{core.@var{pid}}, where
@var{pid} is the inferior process ID.
+If the current inferior's target is non-stop (@pxref{Non-Stop Mode}),
+@value{GDBN} ensures that all the inferior's threads are stopped while
+generating the core dump. @value{GDBN} stops every running threads of
+the inferior before generating the core dump and resumes them when the
+command is done.
+
Note that this command is implemented only for some systems (as of
this writing, @sc{gnu}/Linux, FreeBSD, Solaris, and S390).
Best,
Lancelot.
>
> Thanks.
>
> Reviewed-By: Eli Zaretskii <eliz@gnu.org>
next prev parent reply other threads:[~2023-03-22 16:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 16:51 [PATCH v5] gdb/gcore: interrupt all threads before generating the corefile Lancelot SIX
2023-02-10 14:36 ` [PING] " Lancelot SIX
2023-02-10 21:46 ` Simon Marchi
2023-03-22 16:35 ` [PATCH v6 0/3] interrupt all threads to generate core in non-stop targets Lancelot SIX
2023-03-22 16:35 ` [PATCH v6 1/3] gdb: add inferior parameter to target_is_non_stop_p Lancelot SIX
2023-03-22 16:35 ` [PATCH v6 2/3] gdb/infrun: Improve assertion in stop_all_threads Lancelot SIX
2023-03-22 16:35 ` [PATCH v6 3/3] gdb/gcore: interrupt all threads to generate core in non-stop targets Lancelot SIX
2023-03-22 16:44 ` Eli Zaretskii
2023-03-22 16:59 ` Lancelot SIX [this message]
2023-05-10 18:46 ` Lancelot SIX
2023-05-10 19:05 ` Eli Zaretskii
2023-05-10 19:08 ` Lancelot SIX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0808477-ecd8-9391-9880-b97356928d79@amd.com \
--to=lancelot.six@amd.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).