From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>,
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH] Increase size of main_type::nfields
Date: Wed, 11 Jan 2023 17:33:40 -0500 [thread overview]
Message-ID: <b5f1e9b7-f6d5-de54-d4cf-b131ea9129a5@simark.ca> (raw)
In-Reply-To: <87tu0w69rp.fsf@tromey.com>
On 1/11/23 16:28, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
>
>>> - short nfields;
>>> + int m_nfields;
>
> Simon> Should it be unsigned? I don't recall this field needing to be
> Simon> negative.
>
> I considered it, but the accessor returns int and the setter accepts
> int. So, changing it would perhaps result in a larger patch, but the
> only benefit would be that one could have more than 2 billion constants.
> Even in the realm of generated code this seemed implausible to me.
>
> I could take a look if you think it's worthwhile. I do agree it makes
> more sense, if that helps.
It's not really important from a practical point of view. But also, I'd
be surprised if it broke anything, even without touching the callers.
Simon
next prev parent reply other threads:[~2023-01-11 22:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 20:44 Tom Tromey
2023-01-11 21:02 ` Simon Marchi
2023-01-11 21:28 ` Tom Tromey
2023-01-11 22:33 ` Simon Marchi [this message]
2023-01-12 19:14 ` Tom Tromey
2023-01-13 12:53 ` Pedro Alves
2023-01-27 14:49 ` Tom Tromey
2023-01-27 15:13 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5f1e9b7-f6d5-de54-d4cf-b131ea9129a5@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).