public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@adacore.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tromey@adacore.com>,  Simon Marchi <simark@simark.ca>
Subject: Re: [PATCH] Increase size of main_type::nfields
Date: Fri, 27 Jan 2023 08:13:33 -0700	[thread overview]
Message-ID: <878rhoqaci.fsf@tromey.com> (raw)
In-Reply-To: <061d47f1-fbe7-4d2f-6919-811061d0be9b@simark.ca> (Simon Marchi via Gdb-patches's message of "Wed, 11 Jan 2023 16:02:55 -0500")

>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:

Simon> We could make a test case that generates a source file on the fly in
Simon> standard_output_directory and compiles it.
...
>> -  short nfields;
>> +  int m_nfields;

Simon> Should it be unsigned?  I don't recall this field needing to be
Simon> negative.

I sent v2 with these changes.

Tom

      parent reply	other threads:[~2023-01-27 15:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-11 20:44 Tom Tromey
2023-01-11 21:02 ` Simon Marchi
2023-01-11 21:28   ` Tom Tromey
2023-01-11 22:33     ` Simon Marchi
2023-01-12 19:14       ` Tom Tromey
2023-01-13 12:53   ` Pedro Alves
2023-01-27 14:49     ` Tom Tromey
2023-01-27 15:13   ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rhoqaci.fsf@tromey.com \
    --to=tromey@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).