From: Tom Tromey <tromey@adacore.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>,
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>,
Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH] Increase size of main_type::nfields
Date: Thu, 12 Jan 2023 12:14:02 -0700 [thread overview]
Message-ID: <87a62n5zwl.fsf@tromey.com> (raw)
In-Reply-To: <b5f1e9b7-f6d5-de54-d4cf-b131ea9129a5@simark.ca> (Simon Marchi's message of "Wed, 11 Jan 2023 17:33:40 -0500")
Simon> It's not really important from a practical point of view. But also, I'd
Simon> be surprised if it broke anything, even without touching the callers.
The simplest change needed one cast, but it seems to me that if we want
this to work properly, all callers of num_fields and set_num_fields must
be updated to use unsigned types. I'm looking into that.
Tom
next prev parent reply other threads:[~2023-01-12 19:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 20:44 Tom Tromey
2023-01-11 21:02 ` Simon Marchi
2023-01-11 21:28 ` Tom Tromey
2023-01-11 22:33 ` Simon Marchi
2023-01-12 19:14 ` Tom Tromey [this message]
2023-01-13 12:53 ` Pedro Alves
2023-01-27 14:49 ` Tom Tromey
2023-01-27 15:13 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a62n5zwl.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).