Re: [PATCH v5] [PR python/29603] Disable out-of-scope watchpoints

[Johnson Sun <j3.soon777@gmail.com>]

On 5/11/2023 10:08 AM, SimonMarchi wrote:
> On 5/10/23 13:22, Johnson Sun wrote:
>> Hi,
>>
>> I just applied the patch to commit 39453f9d8cf03b382d34f3548706f1ae5916e34e, and tested with the following commands on a clean Ubuntu 22.04 LTS machine:
>>
>>      make check TESTS="gdb.python/py-watchpoint.exp"
>>      make check TESTS="gdb.python/py-watchpoint.exp" RUNTESTFLAGS="--target_board=native-gdbserver"
>>      make check TESTS="gdb.python/py-watchpoint.exp" RUNTESTFLAGS="--target_board=native-extended-gdbserver"
>>
>> all 3 commands above passed the tests (10/10) on my machine.
>>
>> I'm unsure why the test times out on your machine. Could you provide information regarding the base commit that was used and the operating system installed?
> I just retested on latest master as of now (38b95a529385).
>
> Looking at the output of "set debug infrun", it looks like the program
> is making progress, just that it's really slow, since GDB is single
> stepping all instructions due to the software watchpoint.
>
> Is the printf necessary for the test?  If not, we can remove it.  If the
> loop executes just a few instructions, the program should execute
> relatively quickly, even if single stepping all the way through.
>
> Simon


Hi,

The `printf` statement is not necessary. The tests will still pass after 
removing the `printf` statement and declaring the variable `i` as volatile.

I just sent an updated patch: 
<https://sourceware.org/pipermail/gdb-patches/2023-May/199516.html>

Thank you,

Johnson