Re: [COMMITTED PATCH] Fix procfs.c compilation

[Simon Marchi <simark@simark.ca>]

On 11/30/23 04:54, Rainer Orth wrote:
> procfs.c doesn't currently compile on Solaris:
> 
> /vol/src/gnu/gdb/hg/master/dist/gdb/procfs.c: In member function ‘virtual int procfs_target::can_use_hw_breakpoint(bptype, int, int)’:
> /vol/src/gnu/gdb/hg/master/dist/gdb/procfs.c:3017:9: error: ‘ptr_type’ was not declared in this scope; did you mean ‘var_types’?
>  3017 |   type *ptr_type
>       |         ^~~~~~~~
>       |         var_types
> 
> This was caused by this patch:
> 
> commit 99d9c3b92ca96a7425cbb6b1bf453ede9477a2ee
> Author: Simon Marchi <simon.marchi@efficios.com>
> Date:   Fri Sep 29 14:24:38 2023 -0400
> 
>     gdb: remove target_gdbarch
> 
> Partially undoing it restores the build.
> 
> Tested on amd64-pc-solaris2.11, committed to master.
> 
> Btw., I'd considered reviving the Solaris buildbots to guard against
> this kind of issues.  However, they'd both (sparcv9 and amd64) would
> need to be build-only: the make check phase takes 3-5 times as long as
> the build, there are about 2500 failures and quite a number of those are
> flakey.  I have no idea if the new buildmaster allows for such a
> compile-only configuration, though (the previous one did).
> 
> 	Rainer

Thanks for catching and fixing this.

Having build-only builders would already be really great, I'm pretty
sure it's possible (CCing Mark Wielaard).

If you can identify a few simple and stable tests, it's possible to run
just those (I think that's what the buildbot does even for Linux/x86
today).  It would at least help ensure that GDB is not completely
broken.

Simon